8000 feat: add support for proto.__version__ by parthea · Pull Request #393 · googleapis/proto-plus-python · GitHub
[go: up one dir, main page]
Skip to content

feat: add support for proto.__version__ #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2023
Merged

feat: add support for proto.__version__ #393

merged 1 commit into from
Nov 21, 2023

Conversation

parthea
Copy link
Contributor
@parthea parthea commented Sep 19, 2023

This PR migrates from using a hardcoded version in setup.py to a version module to make it easy to query the current version of proto-plus

(py39) partheniou@partheniou-vm-3:~/git/proto-plus-python$ python3
Python 3.9.16 (main, Mar  2 2023, 17:52:22) 
[GCC 12.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import proto
>>> proto.__version__
'1.22.3'

@parthea parthea requested review from a team as code owners September 19, 2023 17:31
@parthea parthea mentioned this pull request Sep 19, 2023
Merged
@parthea parthea marked this pull request as draft October 2, 2023 17:19
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 21, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 21, 2023
@parthea parthea force-pushed the add-version-module branch 2 times, most recently from bf026a1 to a027eec Compare November 21, 2023 19:32
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 21, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 21, 2023
@parthea parthea marked this pull request as ready for review November 21, 2023 19:34
@parthea parthea merged commit 48cd63f into main Nov 21, 2023
@parthea parthea deleted the add-version-module branch November 21, 2023 20:56
@parthea parthea mentioned this pull request Dec 4, 2023
Closed
@parthea parthea mentioned this pull request Jan 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohmayr ohmayr ohmayr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parthea @ohmayr
0