8000 feat: remove support for Python 3.8 by jackwotherspoon · Pull Request #97 · googleapis/langchain-google-cloud-sql-mysql-python · GitHub
[go: up one dir, main page]
Skip to content

feat: remove support for Python 3.8 #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 26, 2024
Merged

feat: remove support for Python 3.8 #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ef1a33
feat: remove support for Python 3.8
jackwotherspoon Sep 20, 2024
38dab4b
chore: Update sync-repo-settings.yaml
jackwotherspoon Sep 20, 2024
dfa7b49
Merge branch 'main' into py-38
averikitsch Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/sync-repo-settings.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ branchProtectionRules:
requiredStatusCheckContexts:
- "cla/google"
- "lint"
- "mysql-integration-test-pr-py38 (langchain-cloud-sql-testing)"
- "mysql-integration-test-pr-py39 (langchain-cloud-sql-testing)"
- "mysql-integration-test-pr-py310 (langchain-cloud-sql-testing)"
- "mysql-integration-test-pr-py311 (langchain-cloud-sql-testing)"
Expand Down
8 changes: 4 additions & 4 deletions DEVELOPER.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@ These tests are registered as required tests in `.github/sync-repo-settings.yaml

#### Trigger Setup

Cloud Build triggers (for Python versions 3.8 to 3.11) were created with the following specs:
Cloud Build triggers (for Python versions 3.9 to 3.11) were created with the following specs:

```YAML
name: mysql-integration-test-pr-py38
description: Run integration tests on PR for Python 3.8
name: mysql-integration-test-pr-py39
description: Run integration tests on PR for Python 3.9
filename: integration.cloudbuild.yaml
github:
name: langchain-google-cloud-sql-mysql-python
Expand All @@ -55,7 +55,7 @@ substitutions:
_INSTANCE_ID: <ADD_VALUE>
_DB_NAME: <ADD_VALUE>
_REGION: us-central1
_VERSION: "3.8"
_VERSION: "3.9"
```

Use `gcloud builds triggers import --source=trigger.yaml` to create triggers via the command line
Expand Down
2 changes: 1 addition & 1 deletion README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ With `virtualenv`_, it’s possible to install this library without needing syst
Supported Python Versions
^^^^^^^^^^^^^^^^^^^^^^^^^

Python >= 3.8
Python >= 3.9

Mac/Linux
^^^ 8000 ^^^^^^
Expand Down
11 changes: 9 additions & 2 deletions integration.cloudbuild.yaml
View file
Open in desktop
8000
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,14 @@ steps:
- id: Run integration tests
name: python:${_VERSION}
entrypoint: python
args: ["-m", "pytest", "--cov=langchain_google_cloud_sql_mysql", "--cov-config=.coveragerc", "tests/"]
args:
[
"-m",
"pytest",
"--cov=langchain_google_cloud_sql_mysql",
"--cov-config=.coveragerc",
"tests/",
]
env:
- "PROJECT_ID=$PROJECT_ID"
- "INSTANCE_ID=$_INSTANCE_ID"
Expand All @@ -46,7 +53,7 @@ substitutions:
_INSTANCE_ID: test-instance
_REGION: us-central1
_DB_NAME: test
_VERSION: "3.8"
_VERSION: "3.9"

options:
dynamicSubstitutions: true
5 changes: 2 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ dynamic = ["version"]
description = "LangChain integrations for Google Cloud SQL for MySQL"
readme = "README.rst"
license = {file = "LICENSE"}
requires-python = ">=3.8"
requires-python = ">=3.9"
authors = [
{name = "Google LLC", email = "googleapis-packages@google.com"}
]
Expand All @@ -21,7 +21,6 @@ classifiers = [
"License :: OSI Approved :: Apache Software License",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand Down Expand Up @@ -55,7 +54,7 @@ build-backend = "setuptools.build_meta"
profile = "black"

[tool.mypy]
python_version = "3.8"
python_version = "3.9"
warn_unused_configs = true

exclude = [
Expand Down
3 changes: 1 addition & 2 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
langchain==0.2.11
langchain-community==0.2.9
numpy===1.24.4; python_version <= "3.8"
numpy==1.26.4; python_version > "3.8"
numpy==1.26.4
SQLAlchemy==2.0.31
cloud-sql-python-connector[pymysql]==1.11.0

Loading
0