10000 fix: allow similarity search on table names with special characters by jackwotherspoon · Pull Request #65 · googleapis/langchain-google-cloud-sql-mysql-python · GitHub
[go: up one dir, main page]
Skip to content

fix: allow similarity search on table names with special characters #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2024
Merged

fix: allow similarity search on table names with special characters #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/langchain_google_cloud_sql_mysql/vectorstore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,15 +675,15 @@ def _query_collection(
)
if query_options.search_type == SearchType.KNN:
filter = f"WHERE {filter}" if filter else ""
stmt = f"SELECT {column_query}, {distance_function}({self.embedding_column}, string_to_vector('{embedding}')) AS distance FROM {self.table_name} {filter} ORDER BY distance LIMIT {k};"
stmt = f"SELECT {column_query}, {distance_function}({self.embedding_column}, string_to_vector('{embedding}')) AS distance FROM `{self.table_name}` {filter} ORDER BY distance LIMIT {k};"
else:
filter = f"AND {filter}" if filter else ""
num_partitions = (
f",num_partitions={query_options.num_partitions}"
if query_options.num_partitions
else ""
)
stmt = f"SELECT {column_query}, {distance_function}({self.embedding_column}, string_to_vector('{embedding}')) AS distance FROM {self.table_name} WHERE NEAREST({self.embedding_column}) TO (string_to_vector('{embedding}'), 'num_neighbors={k}{num_partitions}') {filter} ORDER BY distance;"
stmt = f"SELECT {column_query}, {distance_function}({self.embedding_column}, string_to_vector('{embedding}')) AS distance FROM `{self.table_name}` WHERE NEAREST({self.embedding_column}) TO (string_to_vector('{embedding}'), 'num_neighbors={k}{num_partitions}') {filter} ORDER BY distance;"

# return self.engine._fetch(stmt)
if map_results:
Expand Down
0