8000
product-auto-label
bot
added
the
api: cloudsql-mysql
Issues related to the googleapis/langchain-google-cloud-sql-mysql-python API.
label
Mar 25, 2024
feat: add MySQLVectorStore initialization methods #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to swap test instance over to instance that has MySQL vector support enabled. |
totoleon
approved these changes
Mar 26, 2024
| ignore_metadata_columns: Optional[List[str]] = None, | ||
| id_column: str = "langchain_id", | ||
| metadata_json_column: Optional[str] = "langchain_metadata", | ||
| index_query_options: Optional[QueryOptions] = None, |
There was a problem hiding this comment.
Better to name it "query_options" instead of index_query_options. In PG QueryOptions is a sub attribute of index, though in Mysql it will be separate. There will be something more than than the index itself such as whether to use KNN query or ANN query, which we call "search_type"
There was a problem hiding this comment.
good idea, done
There was a problem hiding this comment.
Did we want to update to query_options?
There was a problem hiding this comment.
it is updated to query_options, this comment is pinned on out of date code
totoleon
reviewed
Mar 26, 2024
totoleon
suggested changes
Mar 26, 2024
totoleon
reviewed
Mar 26, 2024
totoleon
suggested changes
Mar 26, 2024
totoleon
reviewed
Mar 26, 2024
totoleon
approved these changes
Mar 26, 2024
averikitsch
approved these changes
Mar 26, 2024
| ignore_metadata_columns: Optional[List[str]] = None, | ||
| id_column: str = "langchain_id", | ||
| metadata_json_column: Optional[str] = "langchain_metadata", | ||
| index_query_options: Optional[QueryOptions] = None, |
There was a problem hiding this comment.
Did we want to update to query_options?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
MySQLVectorStoreand all the different class methods to initialize it.Example usage: