8000 docs(samples): Refactoring events package by sborisenkox · Pull Request #419 · googleapis/java-retail · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Oct 3, 2023. It is now read-only.

docs(samples): Refactoring events package #419

Closed
sborisenkox wants to merge 15 commits into from
Closed

docs(samples): Refactoring events package #419

sborisenkox wants to merge 15 commits into from

Conversation

@sborisenkox
Copy link
Contributor
@sborisenkox sborisenkox commented Apr 25, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕ 8000 ️

If you write sample code, please follow the samples format.

@sborisenkox sborisenkox requested review from a team as code owners April 25, 2022 13:13
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: retail Issues related to the googleapis/java-retail API. samples Issues that are directly related to samples. labels Apr 25, 2022
@sborisenkox sborisenkox mentioned this pull request Apr 25, 2022
Closed
4 tasks
Shabirmean
Shabirmean approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor
@Shabirmean Shabirmean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I am a shadow reviewer. So need someone else to review it. Adding @kurtisvg here.

@averikitsch averikitsch added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 12, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2022
@ddixit14 ddixit14 closed this Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@chenlei1216 chenlei1216 chenlei1216 approved these changes

@averikitsch averikitsch averikitsch approved these changes

@Shabirmean Shabirmean Shabirmean approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anguillanneuf anguillanneuf

Labels

api: retail Issues related to the googleapis/java-retail API. kokoro:force-run Add this label to force Kokoro to re-run the tests. samples Issues that are directly related to samples. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@sborisenkox @chenlei1216 @averikitsch @Shabirmean @anguillanneuf @ddixit14 @tetiana-karasova @t-karasova @kweinmeister
0