8000 build: update maven config to use autovalue from shared-config by BenWhitehead · Pull Request #221 · googleapis/java-firestore · GitHub
[go: up one dir, main page]
Skip to content

build: update maven config to use autovalue from shared-config #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BenWhitehead merged 1 commit into from
May 20, 2020
Merged

build: update maven config to use autovalue from shared-config #221

BenWhitehead merged 1 commit into from
May 20, 2020

Conversation

@BenWhitehead
Copy link
Collaborator
@BenWhitehead BenWhitehead commented May 18, 2020

This is expected to not build since it's pointing at a snapshot of shared-config.

But it is illustrative of what the usage of the auto-value profile(s) from shared config look like.

Related to: googleapis/java-shared-config#136

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 18, 2020
@BenWhitehead BenWhitehead mentioned this pull request May 18, 2020
Merged
@codecov
Copy link
codecov bot commented May 20, 2020 •
edited
Loading

Codecov Report

Merging #221 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #221      +/-   ##
============================================
- Coverage     72.94%   72.85%   -0.09%     
+ Complexity     1026     1015      -11     
============================================
  Files            63       63              
  Lines          5407     5394      -13     
  Branches        615      611       -4     
============================================
- Hits           3944     3930      -14     
+ Misses         1266     1265       -1     
- Partials        197      199       +2
Impacted Files Coverage Δ Complexity Δ
...oogle/cloud/firestore/v1/FirestoreAdminClient.java 58.26% <0.00%> (-1.58%) 38.00% <0.00%> (ø%)
...a/com/google/cloud/firestore/FirestoreOptions.java 36.44% <0.00%> (-0.54%) 7.00% <0.00%> (ø%)
...rc/main/java/com/google/cloud/firestore/Query.java 90.80% <0.00%> (-0.17%) 105.00% <0.00%> (-7.00%)
...rc/main/java/com/google/cloud/firestore/Watch.java 91.55% <0.00%> (-0.12%) 56.00% <0.00%> (ø%)
...restore/collection/ImmutableSortedMapIterator.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1023fa...af9a2aa. Read the comment docs.

@BenWhitehead BenWhitehead marked this pull request as ready for review May 20, 2020 19:50
@BenWhitehead BenWhitehead merged commit 8b14331 into googleapis:master May 20, 2020
@BenWhitehead BenWhitehead deleted the autovalue-maven-refactor branch May 20, 2020 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 Awaiting requested review from chingor13

1 more reviewer

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BenWhitehead @stephaniewang526 @googlebot
0