8000 feat: enable grpc configurator for client-side tracing by cindy-peng · Pull Request #1886 · googleapis/java-datastore · GitHub
[go: up one dir, main page]
Skip to content

feat: enable grpc configurator for client-side tracing #1886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: enable grpc configurator for client-side tracing #1886

wants to merge 5 commits into from

Conversation

cindy-peng
Copy link
Contributor
@cindy-peng cindy-peng commented 8000 Jun 17, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@cindy-peng cindy-peng requested review from a team as code owners June 17, 2025 22:30
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: datastore Issues related to the googleapis/java-datastore API. labels Jun 17, 2025
daniel-sanche
daniel-sanche reviewed Jun 18, 2025
View reviewed changes
Copy link
@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I am wondering why the MAX_CHANNEL_COUNT needs to change here

google-cloud-datastore/src/main/java/com/google/cloud/datastore/DatastoreOptions.java
ChannelPoolSettings.builder()
.setInitialChannelCount(INIT_CHANNEL_COUNT)
.setMinChannelCount(MIN_CHANNEL_COUNT)
.setMaxChannelCount(MAX_CHANNEL_COUNT)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to switch to the grpc default instead of explicitly setting MAX_CHANNEL_COUNT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-sanche daniel-sanche daniel-sanche approved these changes

Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/java-datastore API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cindy-peng @daniel-sanche @cloud-java-bot
0