10BC0 Code style cleanup by chingor13 · Pull Request #571 · googleapis/google-http-java-client · GitHub
[go: up one dir, main page]
Skip to content

Code style cleanup #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 13 commits into from
Jan 10, 2019
Merged

Code style cleanup #571

chingor13 merged 13 commits into from
Jan 10, 2019

Conversation

@chingor13
Copy link
Contributor
@chingor13 chingor13 commented Jan 8, 2019

Various style suggestions from internal checkers

chingor13 added 12 commits January 8, 2019 15:01
@chingor13
Code clarity fixes from import
7d6565e
@chingor13
Java suggestion: UnknownHostException is subtype of IOException
bba7845
@chingor13
Java suggestion: params is only assigned during initialization
2a1f342
@chingor13
Java suggestion: simpler equivalent code
99db3dc
@chingor13
Java suggestion: empty array is faster than presized array
e0734ba
@chingor13
Java suggestion: JDK case-related methods depend dangerously on impli…
4525736 
…cit default locale
@chingor13
Java suggestion: method list type can be inferred
c6bc4cd
@chingor13
Java suggestion: remove redundant toString() call on string
33e1cde
@chingor13
Java suggestion: use immutable collections API instead of singleton c…
2886178 
…ollection APIs
@chingor13
Java suggestion: make final tracer/idGenerator only assigned during i…
d62f02c 
…nitialization
@chingor13
Java suggestion: make final tracer only assigned during initialization
b9aacbf
@chingor13
Java style: group overloads together
bc86f28
@chingor13 chingor13 requested a review from a team as a code owner January 8, 2019 23:23
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 8, 2019
@chingor13 chingor13 requested a review from kolea2 January 9, 2019 21:52
@chingor13 chingor13 merged commit c8c44d9 into googleapis:master Jan 10, 2019
@chingor13 chingor13 deleted the internal-cleanup branch January 10, 2019 18:06
@chingor13 chingor13 mentioned this pull request Jan 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chingor13 @kolea2 @googlebot
0