Re-add OpenCensus integration #545

chingor13 · 2018-12-12T00:39:52Z

Fixes #459

This reverts commit 9dd0d1c.

This reverts commit 36280df.

google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java

@@ -883,7 +891,12 @@ public HttpResponse execute() throws IOException {
    Preconditions.checkNotNull(requestMethod);
    Preconditions.checkNotNull(url);

+    Span span = tracer
+        .spanBuilder(OpenCensusUtils.SPAN_NAME_HTTP_REQUEST_EXECUTE)


chingor13 · 2018-12-12T18:43:20Z

The title was correct, this was previously merged, and then reverted due to time crunch on integrating internally.

bogdandrutu · 2018-12-12T19:53:10Z

If possible avoid a high cardinality span name. If the URL does not have a high cardinality and it doesn't use any PII (like resource name) data then should be fine.

bogdandrutu · 2018-12-12T19:54:17Z

See this document https://github.com/census-instrumentation/opencensus-specs/blob/master/trace/HTTP.md

Automation accidentally changed this file.

chingor13 added 3 commits December 11, 2018 16:35

Revert "Revert "Add OpenCensus tracing instrument.""

6f08873

This reverts commit 9dd0d1c.

Revert "Revert "Enhance OpenCensus tracing instrumentation.""

41651a9

This reverts commit 36280df.

Update opencensus version and use dependencyManagement section

cf77d68

chingor13 requested a review from a team as a code owner December 12, 2018 00:39

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 12, 2018

ajaaym reviewed Dec 12, 2018

View reviewed changes

Fix missing import

89a725f

chingor13 requested a review from JesseLovelace December 12, 2018 17:37

ajaaym changed the title ~~Readd OpenCensus integration~~ Read OpenCensus integration Dec 12, 2018

chingor13 changed the title ~~Read OpenCensus integration~~ Re-add OpenCensus integration Dec 12, 2018

chingor13 added 2 commits December 12, 2018 16:54

Set span attributes

bf72917

Fix checkstyle and NPE for missing attributes

fabb6d7

chingor13 mentioned this pull request Dec 13, 2018

Add hooks for instrumenting request timing and getting server IP address #277

Closed

JesseLovelace approved these changes Dec 28, 2018

View reviewed changes

chingor13 merged commit 6f89edc into googleapis:master Dec 28, 2018

chingor13 deleted the opencensus branch December 28, 2018 18:47

This was referenced Jan 3, 2019

Release google-http-java-client v1.28.0 #559

Closed

Release google-http-java-client v1.28.0 #566

Closed

Release google-http-java-client v1.28.0 #574

Merged

elharo pushed a commit that referenced this pull request Mar 13, 2019

revert #545

e808917

clundin25 pushed a commit to clundin25/google-http-java-client that referenced this pull request Aug 11, 2022

chore: revert back to correct license (BSD) (googleapis#545)

4ec16f9

Automation accidentally changed this file.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Re-add OpenCensus integration #545

Re-add OpenCensus integration #545

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Re-add OpenCensus integration #545

Re-add OpenCensus integration #545

Uh oh!

Conversation

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!