8000 XML Parsing: Enum as element type (#475) by geri-m · Pull Request #476 · googleapis/google-http-java-client · GitHub
[go: up one dir, main page]
Skip to content

XML Parsing: Enum as element type (#475) #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2018
Merged

XML Parsing: Enum as element type (#475) #476

merged 2 commits into from
Oct 9, 2018

Conversation

geri-m
Copy link
Contributor
@geri-m geri-m commented Sep 23, 2018

Fixes #475

Note: parseElementInternal in XML.java requires refactoring. Should I handle that right now or are there already other plans in the pipe?

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2018
@chingor13 chingor13 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 24, 2018
@chingor13
Copy link
Collaborator

Re: refactoring, please keep the refactoring separate from any new behavior unless it's necessary for the implementation.

#458 was fixed, so please change this PR to target master

@geri-m geri-m changed the base branch from dev to master September 24, 2018 20:32
@chingor13 chingor13 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 27, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 27, 2018
chingor13
chingor13 approved these changes Oct 9, 2018
View reviewed changes
Copy link
Collaborator
@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This passed internal testing and LGTM.

@chingor13 chingor13 merged commit 4d6a42d into googleapis:master Oct 9, 2018
This was referenced Oct 12, 2018
Closed
Merged
@geri-m geri-m deleted the issue-475 branch November 10, 2018 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@geri-m @chingor13 @googlebot @kokoro-team
0