8000 google-http-client: add STATUS_CODE_ACCEPTED to the list of status codes by mgenov · Pull Request #413 · googleapis/google-http-java-client · GitHub
[go: up one dir, main page]

Skip to content

google-http-client: add STATUS_CODE_ACCEPTED to the list of status codes #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2018

Conversation

mgenov
Copy link
Contributor
@mgenov mgenov commented May 2, 2018

Added constant for STATUS_CODE_ACCEPTED in the HttpStatusCodes interface.

@mgenov mgenov force-pushed the status_code_accepted branch from 2a4ab27 to e8a3104 Compare May 2, 2018 09:28
@jeanbza
Copy link
Contributor
jeanbza commented May 20, 2018

Hello - thanks for contributing. Just a quick update that this repository is currently frozen whilst we fix some backend stuff related to the release process, and submit a release. It should be unfrozen in a few weeks.

More generally, this repository is in maintenance mode; we may not be able to get to this PR for some time.

@mgenov mgenov changed the title gogole-http-client: add STATUS_CODE_ACCEPTED to the list of status codes google-http-client: add STATUS_CODE_ACCEPTED to the list of status codes May 20, 2018
@mgenov
Copy link
Contributor Author
mgenov commented May 20, 2018

@jadekler thanks for your feedback. Will wait till the repository is unfrozen.

@chingor13 chingor13 self-assigned this Aug 15, 2018
@chingor13
Copy link
Collaborator

@mgenov Thanks for contributing!

The linter is failing on the added comment line being too long (over 100 characters). If you can fix it, then we'll get this merged.

@@ -29,6 +29,9 @@
/** Status code for a successful request that has been fulfilled to create a new resource. */
public static final int STATUS_CODE_CREATED = 201;

/** Status code for a successful request that the request has been received but not yet acted upon. */

This comment was marked as spam.

This comment was marked as spam.

@mgenov mgenov force-pushed the status_code_accepted branch from e8a3104 to 62cec10 Compare August 15, 2018 17:53
Added constant for STATUS_CODE_ACCEPTED in the HttpStatusCodes
interface.
@mgenov mgenov force-pushed the status_code_accepted branch from 62cec10 to 929f5f4 Compare August 15, 2018 17:54
Copy link
Collaborator
@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@chingor13 chingor13 merged commit d5ee0c9 into googleapis:dev Aug 15, 2018
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0