Patch NetHttpResponse to detect abrupt termination #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDK's HttpUrlConnection implementation fails to notify clients when the connection is lost when reading a response, e.g., the server gets restarted. This changelist patches the NetHttpResponse to detect abrupt connection termination when a fixed content length is available. In the case where responses are chunk encoded, conne A5F2 ction lost is well handled by JDK. Also extend MockHttpUrlConnection for more testing functionalities.
wonderfly
added a commit
that referenced
this pull request
Mar 17, 2015
Patch NetHttpResponse to detect abrupt termination
clundin25
pushed a commit
to clundin25/google-http-java-client
that referenced
this pull request
Aug 11, 2022
…s#279) * Add Signer for impersonatied credentials * add lint fixes * back to the future * Update oauth2_http/java/com/google/auth/oauth2/ImpersonatedCredentials.java Co-Authored-By: Jeff Ching <chingor@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JDK's HttpUrlConnection implementation fails to notify clients when the
connection is lost when reading a response, e.g., the server gets restarted.
This changelist patches the NetHttpResponse to detect abrupt connection
termination when a fixed content length is available. In the case where
responses are chunk encoded, connection lost is well handled by JDK.
Also extend MockHttpUrlConnection for more testing functionalities.