Fixes #937 - Adds HTTP method and URL to exceptions. #961
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
Addressing comments in review and tox failures.
|
@tseaver PTAL The things left unaddressed from the last PR were as follows: From
From @dhermes: Should we have a newline somewhere in the error message if it gets too long? (I lean towards no because of line wrapping.) |
|
I'm -0 on injecting a newline (thinking e.g. about logfiles: human readability vs. parsing by machine). |
|
WDYT of |
|
I've closed #938 |
|
@tseaver Are we all good then? |
|
LGTM |
|
LGTM - sorry for letting this linger. Thanks for cleaning it up for me :( |
|
No worries @jgeewax |
Fixes #937 - Adds HTTP method and URL to exceptions.
@jgeewax Taking #938 over since it lingered.
@tseaver I rebased and will shortly send another commit addressing review feedback.