fix(bigquery): fix arrow deprecation warning #9504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a warning that can be issued when downloading results as pyarrow record batches.
tswast
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
56DA
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9485.
This PR fixes a warning that can be issued when downloading results as pyarrow record batches.
The warning was caused by
pyarrow, because apyarrowschema was passed as thenamesargument, instead of as theschemaargument, andpyarrowstarted raising a warning for it in version0.15.0(source code).Steps to reproduce
pyarrow0.15.0+ is installed (there is no warning in prior versions),Actual result (before the fix):
A
pyarrowFutureWarning is issued (as described in the issue description).Expected result (after the fix):
No warning is issued, everything works as expected.