8000 test(bigquery): simplify scripting system test to reduce flakiness by tswast · Pull Request #9458 · googleapis/google-cloud-python · GitHub
[go: up one dir, main page]
Skip to content

test(bigquery): simplify scripting system test to reduce flakiness #9458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2019
Merged

test(bigquery): simplify scripting system test to reduce flakiness #9458

merged 1 commit into from
Oct 14, 2019

Conversation

tswast
Copy link
Contributor
@tswast tswast commented Oct 11, 2019

No need to filter by time in the scripting system tests. Rather, we only
care about filtering by parent job when testing those features.

This addresses flakiness encountered:

@tswast tswast requested a review from a team October 11, 2019 23:16
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 11, 2019
@tswast tswast merged commit 8a7eb38 into googleapis:master Oct 14, 2019
@tswast tswast deleted the bq-flakey branch October 14, 2019 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tswast @shollyman @googlebot
0