style(bigquery): add code samples to lint check #9277
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tswast
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9081.
This PR makes sure that the code samples, too, undergo the lint check (
flake8specifically, as black already checks the samples).After experimenting with the synth tool a bit, I realized that the BigQuery's noxfile is not generated by synth from the template, thus modified it directly.
How to test
Introduce a few
flake8-specific (i.e. not relevant toblack) lint errors to some of the files indocs/samples, such as an unused import, and run the lint check:Actual result (before the fix):
The check passes despite the lint issues.
Expected result (before the fix):
The check correctly fails and complains about the lint issues.