8000 BigQuery: Add support for unsetting LoadJobConfig schema by plamut · Pull Request #9077 · googleapis/google-cloud-python · GitHub
[go: up one dir, main page]
Skip to content

BigQuery: Add support for unsetting LoadJobConfig schema #9077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2019
Merged

BigQuery: Add support for unsetting LoadJobConfig schema #9077

merged 1 commit into from
Aug 22, 2019

Conversation

plamut
Copy link
Contributor
@plamut plamut commented Aug 22, 2019

Closes #9074.

This PR adds a public way of unsetting a schema from a LoadJobConfig.

How to test

Create a LoadJobConfig with a schema attribute, then set schema to None --> the schema should be cleared.

@plamut plamut added the api: bigquery Issues related to the BigQuery API. label Aug 22, 2019
@plamut plamut requested review from a team and tswast August 22, 2019 11:49
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 22, 2019
plamut
plamut commented Aug 22, 2019
View reviewed changes
bigquery/tests/unit/test_job.py

config.schema = None
self.assertNotIn("schema", config._properties["load"])
config.schema = None # no error, idempotent operation
Copy link
Contributor Author
@plamut plamut Aug 22, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This extra assignment is to catch fragile implementations such as
del self._properties["load"]["schema"]

(nope, did not do it myself, but I've seen similar bugs in the past 😆 )

tswast
tswast approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor
@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this so quickly!

@tswast tswast merged commit a279630 into googleapis:master Aug 22, 2019
@plamut plamut deleted the iss-9074 branch August 22, 2019 16:18
HemangChothani pushed a commit to HemangChothani/google-cloud-python that referenced this pull request Aug 29, 2019
@plamut @tswast
Add support for unsetting LoadJobConfig schema (googleapis#9077)
18ddd20
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
@plamut @emar-kar
Add support for unsetting LoadJobConfig schema (googleapis#9077)
f86ba32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

Assignees

No one assigned

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BigQuery: LoadJobConfig.schema setter should accept None

3 participants

@plamut @tswast @googlebot
0