8000 BigQuery: Replace avro with arrow schemas in test_table.py by plamut · Pull Request #9056 · googleapis/google-cloud-python · GitHub
[go: up one dir, main page]
Skip to content

BigQuery: Replace avro with arrow schemas in test_table.py #9056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2019
Merged

BigQuery: Replace avro with arrow schemas in test_table.py #9056

merged 1 commit into from
Aug 20, 2019

Conversation

plamut
Copy link
Contributor
@plamut plamut commented Aug 19, 2019

Closes #8855.

This PR removes references to avro schemas in unit tests for table.

How to test

Just make sure there are no avro schemas used in test_table.py anymore, and that test semantics have not changed.

@plamut plamut added the api: bigquery Issues related to the BigQuery API. label Aug 19, 2019
@plamut plamut requested a review from a team August 19, 2019 12:53
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 19, 2019
tswast
tswast approved these changes Aug 19, 2019
View reviewed changes
Copy link
Contributor
@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@plamut plamut merged commit 504cc24 into googleapis:master Aug 20, 2019
@plamut plamut deleted the iss-8855 branch August 20, 2019 05:53
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
@plamut @emar-kar
Replace avro with arrow schemas in test_table.py (googleapis#9056)
ca36002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQuery: Remove references to avro_schema from tests/unit/test_table.py.
3 participants
@plamut @tswast @googlebot
0