10000 BigQuery: Fix the names of several pytest "skip if" markers by plamut · Pull Request #8694 · googleapis/google-cloud-python · GitHub
[go: up one dir, main page]
Skip to content

BigQuery: Fix the names of several pytest "skip if" markers #8694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2019
Merged

BigQuery: Fix the names of several pytest "skip if" markers #8694

merged 1 commit into from
Jul 17, 2019

Conversation

plamut
Copy link
Contributor
@plamut plamut commented Jul 17, 2019

I noticed that running BigQuery unit tests issues some warning, and some of them are caused by using a "skipIf" marker with pytest, while the name of that marker is actually "skipif" (all lowercase).

How to test

Run bigquery unit tests, e.g.:

$ nox -f noxfile.py -s unit-3.6

Actual result (before the fix):
Five warnings are reported, including the "Unknown pytest.mark.skipIf - is this a typo? ...".

Expected result (after the fix):
Only three warnings are reported, but none of them related to pytest markers.

@plamut
Fix several pytest "skip if" markers
18fca96 
"skipif" should be used instead of "skipIf", the latter is the thing
from the unittest nodule.
@plamut plamut added the api: bigquery Issues related to the BigQuery API. label Jul 17, 2019
@plamut plamut requested review from tswast and a team July 17, 2019 16:06
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 17, 2019
tswast
tswast approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor
@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Thank you!

@tswast tswast merged commit a40d0d4 into googleapis:master Jul 17, 2019
71A6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees

@tswast tswast

Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@plamut @tswast @googlebot
0