8000 BigQuery: avoid errors from unknown fields in Models API. by tswast · Pull Request #8083 · googleapis/google-cloud-python · GitHub
[go: up one dir, main page]
Skip to content

BigQuery: avoid errors from unknown fields in Models API. #8083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2019
Merged

BigQuery: avoid errors from unknown fields in Models API. #8083

merged 1 commit into from
May 21, 2019

Conversation

tswast
Copy link
Contributor
@tswast tswast commented May 21, 2019 •
edited
Loading

As new fields are added, the JSON -> Protobuf conversion should not
fail. Instead, it should ignore unknown fields. So that this data is not
discarded, use _properties as is the convention in our REST libraries.
It's private, but can be used as a workaround to get access to fields
that haven't yet been added to the client library.

Closes #8082.

@tswast
Don't raise error when encountering unknown fields in Models API.
d02a076 
As new fields are added, the JSON -> Protobuf conversion should not
fail. Instead, it should ignore unknown fields. So that this data is not
discarded, use _properties as is the convention in our REST libraries.
It's private, but can be used as a workaround to get access to fields
that haven't yet been added to the client library.
@tswast tswast requested review from a team, busunkim96 and shollyman May 21, 2019 16:57
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 21, 2019
@tswast tswast mentioned this pull request May 21, 2019
Merged
@tswast tswast added the api: bigquery Issues related to the BigQuery API. label May 21, 2019
@tseaver tseaver changed the title Don't raise error when encountering unknown fields in Models API. BigQuery: don't raise error when encountering unknown fields in Models API. May 21, 2019
@tseaver tseaver changed the title BigQuery: don't raise error when encountering unknown fields in Models API. BigQuery: avoid errors from unknown fields in Models API. May 21, 2019
@tswast tswast merged commit 25b988f into googleapis:master May 21, 2019
@tswast tswast deleted the issue8082-get_model-unknown-fields branch May 21, 2019 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shollyman shollyman Awaiting requested review from shollyman

@busunkim96 busunkim96 Awaiting requested review from busunkim96

1 more reviewer

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BQML get_model snippets tests are failing

3 participants

@tswast @tseaver @googlebot
0