10000 Adding missing properties from LoadJobConfig to LoadJob library by lbristol88 · Pull Request #7710 · googleapis/google-cloud-python · GitHub
[go: up one dir, main page]
Skip to content

Adding missing properties from LoadJobConfig to LoadJob library #7710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 15, 2019
Merged

Adding missing properties from LoadJobConfig to LoadJob library #7710

merged 4 commits into from
Apr 15, 2019
+40 −1

Conversation

lbristol88
Copy link
Contributor
@lbristol88 lbristol88 commented Apr 15, 2019 •
edited by tswast
Loading

@lbristol88 lbristol88 requested a review from crwilcox as a code owner April 15, 2019 19:52
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 15, 2019
tswast
tswast reviewed Apr 15, 2019
View reviewed changes
Copy link
Contributor
@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once there is a test for non-None description and friendly name.

bigquery/tests/unit/test_job.py Outdated
else:
self.assertIsNone(job.destination_encryption_configuration)

if "destinationTableDescription" in config:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, _verifyResourceProperties isn't a very good example to follow. I prefer explicitly setting the values you are looking for in the test itself.

Please remove this code and add check for string values for destination_table_description and destination_table_friendly_name to test_ctor_w_config.

@tswast tswast added api: bigquery Issues related to the BigQuery API. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 15, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 15, 2019
@tswast tswast merged commit 785c907 into googleapis:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQuery: Add missing configuration properties to LoadJob
4 participants
@lbristol88 @tswast @googlebot @yoshi-kokoro
0