10BC0 Adding `clustering_fields` property to TableListItem by lbristol88 · Pull Request #7692 · googleapis/google-cloud-python · GitHub
[go: up one dir, main page]
Skip to content

Adding clustering_fields property to TableListItem #7692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2019
Merged

Adding clustering_fields property to TableListItem #7692

merged 2 commits into from
Apr 10, 2019
+20 −0

Conversation

lbristol88
Copy link
Contributor

@lbristol88 lbristol88 requested a review from crwilcox as a code owner April 10, 2019 18:21
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 10, 2019
tswast
tswast requested changes Apr 10, 2019
View reviewed changes
Copy link
Contributor
@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a non-None test to test_ctor as well? It's important to test both cases.

@lbristol88
Copy link
Contributor Author

Added the assert is not none for clustering fields in test_ctor and moved the assertIsNone test to the appropriate test_ctor missing properties collection.

@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 10, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 10, 2019
@tswast tswast merged commit ed3b321 into googleapis:master Apr 10, 2019
tswast pushed a commit to tswast/google-cloud-python that referenced this pull request Apr 11, 2019
@lbristol88 @tswast
Adding clustering_fields property to TableListItem (googleapis#7692)
2776aed 
* Added property clustering_fields to TableListItem along with test

* Updated tests for clustering fields.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
4765
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lbristol88 @tswast @googlebot @yoshi-kokoro
0