Call get_table automatically in list_rows if the schema is not available #7621
+77
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is kinder than raising an error message saying to call get_table yourself. Also, it guarantees the schema is as up-to-date as possible. This also fixes an issue where rows could not be listed on the TableListItem objects that are returned from list_tables.
tseaver
reviewed
Mar 30, 2019
| # columns, so get the table resource for them rather than failing. | ||
| elif len(schema) == 0: | ||
| table = self.get_table(table.reference, retry=retry) | ||
| schema = table.schema |
There was a problem hiding this comment.
Doing the extra API round-trip is certainly friendlier, but it makes the programming error more expensive (in time / billing). I guess that is a reasonable tradeoff.
tseaver
approved these changes
Mar 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is kinder than raising an error message saying to call
get_tableyourself. Also, it guarantees the schema is as up-to-date as possible.
This also fixes an issue where rows could not be listed on the
TableListItemobjects that are returned fromlist_tables.