10BC0 remove iam module from core by crwilcox · Pull Request #6775 · googleapis/google-cloud-python · GitHub
[go: up one dir, main page]
Skip to content

remove iam module from core #6775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 3, 2018
Merged

remove iam module from core #6775

merged 7 commits into from
Dec 3, 2018

Conversation

crwilcox
Copy link
Contributor

iam was moved to API Core.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 30, 2018
@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2018
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2018
@crwilcox crwilcox requested a review from tseaver December 3, 2018 20:53
@crwilcox
Copy link
Contributor Author
crwilcox commented Dec 3, 2018

CircleCI is failing for missing module. That is getting fixed in #6741

@crwilcox crwilcox requested a review from theacodes as a code owner December 3, 2018 22:40
tseaver
tseaver reviewed Dec 3, 2018
View reviewed changes
@crwilcox crwilcox merged commit 689486f into master Dec 3, 2018
@crwilcox crwilcox deleted the remove-iam-from-core branch December 4, 2018 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theacodes theacodes Awaiting requested review from theacodes

1 more reviewer

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crwilcox @tseaver @googlebot @yoshi-kokoro
0