8000 [DO NOT MERGE] Bigtable: pick up fixes in GAPIC generator. by yoshi-automation · Pull Request #6492 · googleapis/google-cloud-python · GitHub
[go: up one dir, main page]
Skip to content

[DO NOT MERGE] Bigtable: pick up fixes in GAPIC generator. #6492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yoshi-automation wants to merge 1 commit into from
Closed

[DO NOT MERGE] Bigtable: pick up fixes in GAPIC generator. #6492

yoshi-automation wants to merge 1 commit into from

Conversation

@yoshi-automation
Copy link
Contributor
@yoshi-automation yoshi-automation commented Nov 14, 2018

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Cloning googleapis.
synthtool > Running generator for google/bigtable/artman_bigtable.yaml.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:90f9d15e9bad675aeecd586725bce48f5667ffe7d5fc4d1e96d51ff34304815b
Status: Image is up to date for googleapis/artman:latest
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/bigtable-v2.
synthtool > Running generator for google/bigtable/admin/artman_bigtableadmin.yaml.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:90f9d15e9bad675aeecd586725bce48f5667ffe7d5fc4d1e96d51ff34304815b
Status: Image is up to date for googleapis/artman:latest
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/bigtable-admin-v2.
synthtool > Replaced "'google-cloud-bigtable-admin'" in google/cloud/bigtable_admin_v2/gapic/bigtable_instance_admin_client.py.
synthtool > Replaced "'google-cloud-bigtable-admin'" in google/cloud/bigtable_admin_v2/gapic/bigtable_table_admin_client.py.
synthtool > Replaced 'from google\\.cloud\\.bigtable\\.admin_v2.proto' in google/cloud/bigtable_admin_v2/proto/bigtable_table_admin_pb2_grpc.py.
synthtool > Replaced 'from google\\.cloud\\.bigtable\\.admin_v2.proto' in google/cloud/bigtable_admin_v2/proto/bigtable_table_admin_pb2.py.
synthtool > Replaced 'from google\\.cloud\\.bigtable\\.admin_v2.proto' in google/cloud/bigtable_admin_v2/proto/instance_pb2.py.
synthtool > Replaced 'from google\\.cloud\\.bigtable\\.admin_v2.proto' in google/cloud/bigtable_admin_v2/proto/bigtable_instance_admin_pb2.py.
synthtool > Replaced 'from google\\.cloud\\.bigtable\\.admin_v2.proto' in google/cloud/bigtable_admin_v2/proto/bigtable_instance_admin_pb2_grpc.py.
synthtool > Replaced 'google.api_core.grpc_helpers.create_channel\\(\n(\\s+)address.*\n\\s+credentials.*\n\\s+scopes.*\n' in google/cloud/bigtable_admin_v2/gapic/transports/bigtable_table_admin_grpc_transport.py.
synthtool > Replaced 'google.api_core.grpc_helpers.create_channel\\(\n(\\s+)address.*\n\\s+credentials.*\n\\s+scopes.*\n' in google/cloud/bigtable_v2/gapic/transports/bigtable_grpc_transport.py.
synthtool > Replaced '    __doc__ = bigtable_instance_admin_client.BigtableInstanceAdminClient.__doc__\n' in google/cloud/bigtable_admin_v2/__init__.py.
synthtool > Cleaned up 0 temporary directories.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 14, 2018
@tseaver tseaver changed the title [CHANGE ME] Re-generated bigtable to pick up changes in the API or client library generator. [DO NOT MERGE] Bigtable: pick up fixes in GAPIC generator. Nov 14, 2018
tseaver
tseaver reviewed Nov 14, 2018
View reviewed changes
Copy link
Contributor
@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codegen is busted:

  File "/var/code/gcp/bigtable/google/cloud/bigtable/__init__.py", line 21, in <module>
    from google.cloud.bigtable.client import Client
  File "/var/code/gcp/bigtable/google/cloud/bigtable/client.py", line 40, in <module>
    from google.cloud.bigtable.instance import Instance
  File "/var/code/gcp/bigtable/google/cloud/bigtable/instance.py", line 20, in <module>
    from google.cloud.bigtable.table import Table
  File "/var/code/gcp/bigtable/google/cloud/bigtable/table.py", line 37, in <module>
    from google.cloud.bigtable import enums
  File "/var/code/gcp/bigtable/google/cloud/bigtable/enums.py", line 19, in <module>
    class StorageType(object):
  File "/var/code/gcp/bigtable/google/cloud/bigtable/enums.py", line 28, in StorageType
    UNSPECIFIED = enums.StorageType.STORAGE_TYPE_UNSPECIFIED
AttributeError: module 'google.cloud.bigtable_admin_v2.gapic.enums' has no attribute 'StorageType'

@tseaver tseaver added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: bigtable Issues related to the Bigtable API. codegen kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 14, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 14, 2018
@tseaver tseaver mentioned this pull request Nov 14, 2018
Closed
@tseaver tseaver added the status: blocked Resolving the issue is dependent on other work. label Nov 14, 2018
@tseaver
Copy link
Contributor
tseaver commented Nov 14, 2018

I verified the breakage locally. See googleapis/gapic-generator#2429.
8000

@andreamlin
Copy link
Contributor
andreamlin commented Nov 19, 2018

Hmm, this might have been my breakage: googleapis/gapic-generator#2441

@andreamlin
Copy link
Contributor
andreamlin commented Nov 19, 2018

We're planning on having artman smoketests run on gapic-generator check-ins so that we don't have these kinda breakages down the road. (ex googleapis/gapic-generator#2443)

@andreamlin andreamlin mentioned this pull request Nov 19, 2018
Merged
@tseaver tseaver mentioned this pull request Nov 21, 2018
Merged
@tseaver
Copy link
Contributor
tseaver commented Nov 21, 2018

Superseded by #6630.

tseaver added a commit that referenced this pull request Nov 21, 2018
@tseaver
Bigtable: pick up fixes to GAPIC generator. (#6630)
f550aba 
Includes fixes from these PRs:

- googleapis/gapic-generator#2407
- googleapis/gapic-generator#2396

Includes changes to generated tests.

Closes #6492.
@tseaver tseaver deleted the autosynth-bigtable branch November 21, 2018 15:35
parthea pushed a commit that referenced this pull request Nov 22, 2025
@tseaver
Bigtable: pick up fixes to GAPIC generator. (#6630)
9e4f24e 
Includes fixes from these PRs:

- googleapis/gapic-generator#2407
- googleapis/gapic-generator#2396

Includes changes to generated tests.

Closes #6492.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

1 more reviewer

@tseaver tseaver tseaver left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement. codegen do not merge Indicates a pull request not ready for merge, due to either quality or timing. status: blocked Resolving the issue is dependent on other work.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yoshi-automation @tseaver @andreamlin @googlebot @kokoro-team
0