8000 api_core: retry transient errors in 'PollingFuture.result'. by tseaver · Pull Request #6305 · googleapis/google-cloud-python · GitHub
[go: up one dir, main page]
Skip to content

api_core: retry transient errors in 'PollingFuture.result'. #6305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2018
Merged

api_core: retry transient errors in 'PollingFuture.result'. #6305

merged 1 commit into from
Oct 31, 2018
+35 −1

Conversation

tseaver
Copy link
Contributor
@tseaver tseaver commented Oct 25, 2018

See: #6301.

@tseaver tseaver requested a review from crwilcox as a code owner October 25, 2018 17:08
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 25, 2018
This was referenced Oct 25, 2018
Closed
Merged
@tseaver
Copy link
Contributor Author
tseaver commented Oct 29, 2018

@crwilcox ping?

@crwilcox
Copy link
Contributor

This LGTM. We retry those errors in some libraries explicitly and they should be retry-able. If not in a hurry, it might be nice to get @theacodes to sign off as well.

@tseaver tseaver requested a review from theacodes October 30, 2018 19:46
@tseaver tseaver merged commit f576d14 into googleapis:master Oct 31, 2018
@tseaver tseaver deleted the api_core-future-retry_transient_errors branch October 31, 2018 14:14
@tseaver tseaver mentioned this pull request Dec 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@theacodes theacodes theacodes approved these changes

@crwilcox crwilcox crwilcox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: core cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver @crwilcox @theacodes @googlebot
0