8000 BigQuery: use _get_sub_prop helper so missing load stats don't raise. by hrfuller · Pull Request #6269 · googleapis/google-cloud-python · GitHub
[go: up one dir, main page]

Skip to content

Conversation

hrfuller
Copy link
Contributor

No description provided.

@hrfuller hrfuller requested a review from crwilcox as a code owner October 18, 2018 18:50
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 18, 2018
@hrfuller hrfuller force-pushed the fix/load-stats-keyerror branch from 8a34642 to 1eceb60 Compare October 18, 2018 18:57
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 18, 2018
@tseaver tseaver added the api: bigquerydatatransfer Issues related to the BigQuery Data Transfer Service API. label Oct 18, 2018
return int(statistics['load']['inputFileBytes'])
return _helpers._get_sub_prop(
self._properties, ['statistics', 'load', 'inputFileBytes']
)

This comment was marked as spam.

return int(statistics['load']['inputFiles'])
return _helpers._get_sub_prop(
self._properties, ['statistics', 'load', 'inputFiles']
)

This comment was marked as spam.

return int(statistics['load']['outputBytes'])
return _helpers._get_sub_prop(
self._properties, ['statistics', 'load', 'outputBytes']
)

This comment was marked as spam.

8000
return int(statistics['load']['outputRows'])
return _helpers._get_sub_prop(
self._properties, ['statistics', 'load', 'outputRows']
)

This comment was marked as spam.

@tseaver tseaver added api: bigquery Issues related to the BigQuery API. and removed api: bigquerydatatransfer Issues related to the BigQuery Data Transfer Service API. labels Oct 18, 2018
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 18, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 18, 2018
@tseaver tseaver removed the request for review from crwilcox October 18, 2018 21:42
@tseaver
Copy link
Contributor
tseaver commented Oct 18, 2018

@dpebot merge when green, please.

@dpebot
Copy link
Contributor
dpebot commented Oct 18, 2018

Okay! I'll merge when all statuses are green and all reviewers approve.

@dpebot dpebot added the automerge Merge the pull request once unit tests and other checks pass. label Oct 18, 2018
@dpebot dpebot self-assigned this Oct 18, 2018
@tseaver
Copy link
Contributor
tseaver commented Oct 19, 2018

@theacodes I have no idea why @dpebot drops the ball on this one.

@tseaver tseaver merged commit 333c52a into googleapis:master Oct 19, 2018
@tseaver
Copy link
Contributor
tseaver commented Oct 19, 2018

@hrfuller Thanks for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API. automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

0