8000 Logging: add 'synth.py'. by tseaver · Pull Request #6081 · googleapis/google-cloud-python · GitHub
[go: up one dir, main page]
Skip to content

Logging: add 'synth.py'.#6081

Merged
tseaver merged 1 commit intomasterfrom
6073-logging_add_synth
Oct 31, 2018
Merged

Logging: add 'synth.py'.#6081
tseaver merged 1 commit intomasterfrom
6073-logging_add_synth

Conversation

@tseaver
Copy link
Contributor
@tseaver tseaver commented Sep 24, 2018

Closes #6073.

@lukesneeringer Note that this PR has the same issue as #5952 (missing google.api.MonitoredResourceMetadata definition).

@tseaver tseaver added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: logging Issues related to the Cloud Logging API. codegen labels Sep 24, 2018
@tseaver tseaver requested a review from theacodes as a code owner September 24, 2018 18:09
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 24, 2018
@tseaver tseaver mentioned this pull request Sep 24, 2018
Closed
@tseaver tseaver requested a review from crwilcox September 24, 2018 21:09
@tseaver
Copy link
Contributor Author
tseaver commented Sep 24, 2018

@lukesneeringer We need a non-beta release of googleapis-common-protos 1.6.0 to make synth.py work against current protos for logging (and monitoring, as in PR #5952).

@lukesneeringer
Copy link
Contributor
lukesneeringer commented Sep 24, 2018

@lukesneeringer We need a non-beta release of googleapis-common-protos 1.6.0 to make synth.py work against current protos for logging (and monitoring, as in PR #5952).

Ack, thank you -- I did not realize this.
I will get you a 1.5.4 soon with this added (I am not ready to push out the real 1.6.0 yet.)

I need to make a sanity check with Jon Skeet before I can do it, so ETA tomorrow.

@tseaver
Copy link
Contributor Author
tseaver commented Sep 25, 2018

@lukesneeringer Will the googleapis-common-protos 1.5.4 release contain the google.api.MonitoredResource{,Metadata} messages?

@tseaver tseaver mentioned this pull request Sep 25, 2018
Closed
@tseaver tseaver added the status: blocked Resolving the issue is dependent on other work. label Sep 25, 2018
@tseaver
Copy link
Contributor Author
tseaver commented Oct 1, 2018

@lukesneeringer I see a couple of new beta releases since last week for googleapis-common-protos (1.6.0b5 and 1.6.0b6), but no 1.5.4: is there an issue blocking its release?

@tseaver
Copy link
Contributor Author
tseaver commented Oct 9, 2018

@lukesneeringer ping?

@tseaver tseaver mentioned this pull request Oct 17, 2018
Merged
@tseaver tseaver force-pushed the 6073-logging_add_synth branch from 38cf5b1 to b7db900 Compare October 31, 2018 20:25
@tseaver tseaver removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. status: blocked Resolving the issue is dependent on other work. labels Oct 31, 2018
@tseaver
Copy link
Contributor Author
tseaver commented Oct 31, 2018

Thanks, @lukesneeringer -- googleapis-common-protos 1.5.5 is what this PR needed.

@tseaver tseaver force-pushed the 6073-logging_add_synth branch from b7db900 to c529530 Compare October 31, 2018 20:31
@tseaver
Copy link
Contributor Author
tseaver commented Oct 31, 2018

W00t! All green is a nice relief. @crwilcox, @theacodes PTAL.

@tseaver tseaver merged commit da9a1b0 into master Oct 31, 2018
@tseaver tseaver deleted the 6073-logging_add_synth branch October 31, 2018 20:54
parthea pushed a commit that referenced this pull request Nov 24, 2025
@tseaver
Logging: add 'synth.py'. (#6081)
9823c93 
Closes #6073.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

1 more reviewer

@theacodes theacodes theacodes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lukesneeringer lukesneeringer

Labels

api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement. codegen

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver @lukesneeringer @theacodes @googlebot
0