8000 Release bigquery 1.1.0 by crwilcox · Pull Request #5208 · googleapis/google-cloud-python · GitHub
[go: up one dir, main page]
Skip to content

Release bigquery 1.1.0#5208

Merged
crwilcox merged 2 commits intomasterfrom
release-bigquery-1.1.0
Apr 18, 2018
Merged

Release bigquery 1.1.0#5208
crwilcox merged 2 commits intomasterfrom
release-bigquery-1.1.0

Conversation

@crwilcox
Copy link
Contributor
@crwilcox crwilcox commented Apr 18, 2018

This pull request was generated using releasetool.

@crwilcox crwilcox requested review from tseaver and tswast as code owners April 18, 2018 19:35
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 18, 2018
@crwilcox crwilcox requested a review from alixhami April 18, 2018 19:58
@tseaver tseaver added api: bigquery Issues related to the BigQuery API. packaging type: process A process-related concern. May include testing, release, or the like. labels Apr 18, 2018
@tseaver
Copy link
Contributor
tseaver commented Apr 18, 2018

@crwilcox Are we fixing the fact that we tagged bigquery-1.0.1 at a revision which included a new feature, and therefore should have been bigquery-1.1.0?

@tseaver
Copy link
Contributor
tseaver commented Apr 18, 2018

Also, the CI failure is due to #5003, which shouldn't block the merge / release.

@tseaver
Copy link
Contributor
tseaver commented Apr 18, 2018 •
edited
Loading

Looks like the merge of PR #5206 didn't create a PyPI release for the abortive bigquery-1.0.1 tag (or did somebody remove it?) The tag, at least, still exists here.

@crwilcox
Copy link
Contributor Author
crwilcox commented Apr 18, 2018

I was trying to do a targeted patch, but our tooling doesn't really support this. The previous release was just wrong because of that so I am retagging with a the proper semver. Plus the previous failed to build on circle so I had to rebuild anyway :)

tswast
tswast approved these changes Apr 18, 2018
View reviewed changes
Copy link
Contributor
@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog LGTM.

@tswast
Copy link
Contributor
tswast commented Apr 18, 2018

I'm surprised we still don't see the actual test names in the CircleCI output. I'd very much like to know which test is stalling.

@crwilcox crwilcox merged commit 7872d93 into master Apr 18, 2018
@crwilcox crwilcox deleted the release-bigquery-1.1.0 branch April 18, 2018 20:52
@crwilcox
Copy link
Contributor Author
crwilcox commented Apr 18, 2018

Release is at https://github.com/GoogleCloudPlatform/google-cloud-python/releases/tag/bigquery-1.1.0.

@crwilcox
Copy link
Contributor Author
crwilcox commented Apr 18, 2018

manually published to pypi

@tswast
Copy link
Contributor
tswast commented Apr 19, 2018

Thanks @crwilcox.

With the CI failure, I think a manual docs push may be needed, too. I'm only seeing 1.0 in the changelog there.

@crwilcox
Copy link
Contributor Author
crwilcox commented Apr 19, 2018

@tswast sure. I am not familiar with how push docs manually. Do you know or @jonparrott perhaps?

@tswast
Copy link
Contributor
tswast commented Apr 20, 2018 •
edited
Loading

nox -s docs from root dir in master/desired tag and overwrite the "latest" directory in the gh-pages branch. https://github.com/GoogleCloudPlatform/google-cloud-python/tree/gh-pages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

@tseaver tseaver Awaiting requested review from tseaver

@alixhami alixhami Awaiting requested review from alixhami

Assignees

No one assigned

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. packaging type: process A process-related concern. May include testing, release, or the like.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crwilcox @tseaver @tswast @googlebot
0