8000
  • #485: Drop Query use of Dataset object by tseaver · Pull Request #498 · googleapis/google-cloud-python · GitHub
    [go: up one dir, main page]
    Skip to content

    #485: Drop Query use of Dataset object#498

    Merged
    tseaver merged 5 commits intogoogleapis:masterfrom
    tseaver:485-remove_dataset_obj_from_query
    Jan 7, 2015
    Merged

    #485: Drop Query use of Dataset object#498
    tseaver merged 5 commits intogoogleapis:masterfrom
    tseaver:485-remove_dataset_obj_from_query

    Conversation

    @tseaver
    Copy link
    Contributor
    @tseaver tseaver commented Jan 7, 2015

    Instead, dataset_id and connection are passed in, or derived from
    the implicit environ.

    Fixes #485.

    @tseaver
    #485: drop Query dep. on Dataset object.
    09ece55 
    Instead, 'dataset_id' and 'connection' are passed in, or derived from
the implicit environ.

Fixes #485.
    @dhermes
    Copy link
    Contributor
    dhermes commented Jan 7, 2015

    Lint points out you should change Query base class back to object.

    dhermes
    dhermes reviewed Jan 7, 2015
    View reviewed changes
    gcloud/datastore/query.py

    This comment was marked as spam.

    Sign in to view

    This comment was marked as spam.

    Sign in to view

    This comment was marked as spam.

    Sign in to view

    @dhermes
    Copy link
    Contributor
    dhermes commented Jan 7, 2015

    LGTM pending Query subclass fix.

    Feel free to merge, but I'd still love some comments on my comments.

    @coveralls
    Copy link
    coveralls commented Jan 7, 2015

    Coverage Status

    Coverage remained the same when pulling cec3a39 on tseaver:485-remove_dataset_obj_from_query into 87273a1 on GoogleCloudPlatform:master.

    @tseaver tseaver mentioned this pull request Jan 7, 2015
    Merged
    tseaver added a commit that referenced this pull request Jan 7, 2015
    @tseaver
    Merge pull request #498 from tseaver/485-remove_dataset_obj_from_query
    9bafba0 
    #485: Drop Query use of Dataset object
    @tseaver tseaver merged commit 9bafba0 into googleapis:master Jan 7, 2015
    @tseaver tseaver deleted the 485-remove_dataset_obj_from_query branch January 7, 2015 17:41
    @dhermes dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015
    tswast added a commit to tswast/google-cloud-python that referenced this pull request Mar 26, 2019
    @tswast
    Add Beta client status to Models API methods. (googleapis#498)
    9a71095 
    Even if the Models API itself is considered GA, I'd like to mark the
client methods as Beta for a time to give us some more ability to make
breaking changes until we're sure of the public interface we want to
expose.
    atulep pushed a commit that referenced this pull request Apr 6, 2023
    @gcf-owl-bot @parthea
    chore(python): upgrade gcp-releasetool in .kokoro [autoapprove] (#498)
    2a5ca85 
    * chore(python): upgrade gcp-releasetool in .kokoro [autoapprove]

Source-Link: googleapis/synthtool@5f2a608
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97

* trigger ci

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
    atulep pushed a commit that referenced this pull request Apr 18, 2023
    @gcf-owl-bot @parthea
    chore(python): upgrade gcp-releasetool in .kokoro [autoapprove] (#498)
    6694fa4 
    * chore(python): upgrade gcp-releasetool in .kokoro [autoapprove]

Source-Link: googleapis/synthtool@5f2a608
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97

* trigger ci

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
    parthea pushed a commit that referenced this pull request Aug 15, 2023
    @gcf-owl-bot
    chore: fix prerelease_deps nox session [autoapprove] (#498)
    865ff90 
    Source-Link: https://togithub.com/googleapis/synthtool/commit/26c7505b2f76981ec1707b851e1595c8c06e90fc
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f946c75373c2b0040e8e318c5e85d0cf46bc6e61d0a01f3ef94d8de974ac6790
    vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
    @gcf-owl-bot
    chore(python): refactor unit / system test dependency install (#498)
    c768a1e 
    Source-Link: googleapis/synthtool@993985f
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1894490910e891a385484514b22eb5133578897eb5b3c380e6d8ad475c6647cd
    parthea added a commit that referenced this pull request Sep 22, 2023
    @parthea
    chore: Delete obsolete samples/snippets directory (#498)
    52a0641
    parthea pushed a commit that referenced this pull request Sep 22, 2023
    @release-please
    chore(main): release 3.12.1 (#498)
    ff2173e 
    Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
    parthea pushed a commit that referenced this pull request Oct 21, 2023
    @renovate-bot
    chore(deps): update dependency google-cloud-asset to v3.14.0 (#498)
    3c3eee4
    parthea pushed a commit that referenced this pull request Oct 21, 2023
    @renovate-bot
    chore(deps): update dependency google-cloud-monitoring to v2.11.2 (#498)
    e04c45a
    parthea pushed a commit that referenced this pull request Oct 21, 2023
    @gcf-owl-bot
    chore: Update gapic-generator-python to v1.11.2 (#498)
    a42f22e 
    * chore: Update gapic-generator-python to v1.11.2

PiperOrigin-RevId: 546510849

Source-Link: googleapis/googleapis@736073a

Source-Link: googleapis/googleapis-gen@deb64e8
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGViNjRlOGVjMTlkMTQxZTMxMDg5ZmU5MzJiM2E5OTdhZDU0MWM0ZCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    parthea added a commit that referenced this pull request Oct 21, 2023
    @gcf-owl-bot @parthea
    fix(deps): Require google-api-core >=1.34.0, >=2.11.0 (#498)
    2c2516b 
    * chore: update to gapic-generator-python 1.5.0

feat: add support for `google.cloud.<api>.__version__`
PiperOrigin-RevId: 484665853

Source-Link: googleapis/googleapis@8eb249a

Source-Link: googleapis/googleapis-gen@c8aa327
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzhhYTMyN2I1ZjQ3ODg2NWZjM2ZkOTFlM2MyNzY4ZTU0ZTI2YWQ0NCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: Update to gapic-generator-python 1.6.0

feat(python): Add typing to proto.Message based class attributes

feat(python): Snippetgen handling of repeated enum field

PiperOrigin-RevId: 487326846

Source-Link: googleapis/googleapis@da380c7

Source-Link: googleapis/googleapis-gen@61ef576
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjFlZjU3NjJlZTY3MzFhMGNiYmZlYTIyZmQwZWVjZWU1MWFiMWM4ZSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat: new APIs added to reflect updates to the filestore service

- Add ENTERPRISE Tier
- Add snapshot APIs: RevertInstance, ListSnapshots, CreateSnapshot, DeleteSnapshot, UpdateSnapshot
- Add multi-share APIs: ListShares, GetShare, CreateShare, DeleteShare, UpdateShare
- Add ConnectMode to NetworkConfig (for Private Service Access support)
- New status codes (SUSPENDED/SUSPENDING, REVERTING/RESUMING)
- Add SuspensionReason (for KMS related suspension)
- Add new fields to Instance information: max_capacity_gb, capacity_step_size_gb, max_share_count, capacity_gb, multi_share_enabled

PiperOrigin-RevId: 487492758

Source-Link: googleapis/googleapis@5be5981

Source-Link: googleapis/googleapis-gen@ab0e217
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWIwZTIxN2Y1NjBjYzJjMWFmYzExNDQxYzJlYWI2YjY5NTBlZmQyYiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: Update gapic-generator-python to v1.6.1

PiperOrigin-RevId: 488036204

Source-Link: googleapis/googleapis@08f275f

Source-Link: googleapis/googleapis-gen@555c094
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTU1YzA5NDVlNjA2NDllMzg3MzlhZTY0YmM0NTcxOWNkZjcyMTc4ZiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: use templated setup.py and owlbot.py

* remove v1p1beta1 docs

* set coverage to 99

* remove commented code

* fix(deps): Require google-api-core >=1.34.0, >=2.11.0

fix: Drop usage of pkg_resources

fix: Fix timeout default values

docs(samples): Snippetgen should call await on the operation coroutine before calling result

PiperOrigin-RevId: 493260409

Source-Link: googleapis/googleapis@fea4387

Source-Link: googleapis/googleapis-gen@387b734
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzg3YjczNDRjNzUyOWVlNDRiZTg0ZTYxM2IxOWE4MjA1MDhjNjEyYiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* add gapic_version.py

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
    parthea pushed a commit that referenced this pull request Oct 21, 2023
    @gcf-owl-bot
    build(deps): [autoapprove] bump pygments from 2.13.0 to 2.15.0 (#498)
    5be58e0 
    Source-Link: googleapis/synthtool@eaef28e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f8ca7655fa8a449cadcabcbce4054f593dcbae7aeeab34aa3fcc8b5cf7a93c9e

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    parthea added a commit that referenced this pull request Oct 22, 2023
    @gcf-owl-bot @parthea
    chore(python): upgrade gcp-releasetool in .kokoro [autoapprove] (#498)
    fff0b4a 
    * chore(python): upgrade gcp-releasetool in .kokoro [autoapprove]

Source-Link: googleapis/synthtool@5f2a608
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97

* trigger ci

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
    parthea pushed a commit that referenced this pull request Aug 21, 2025
    @renovate-bot
    chore(deps): update dependency pandas to v1.4.4 (#498)
    41b9252
    parthea pushed a commit that referenced this pull request Sep 16, 2025
    @renovate-bot @parthea
    chore(deps): update dependency pandas to v1.4.4 (#498)
    a5de97e
    parthea added a commit that referenced this pull request Sep 18, 2025
    @renovate-bot @parthea
    chore(deps): update all dependencies (#498)
    7ee5b18 
    * chore(deps): update all dependencies

* revert change

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
    parthea pushed a commit that referenced this pull request Nov 22, 2025
    @renovate-bot
    chore(deps): update all dependencies (#498)
    8a2e0b7
    parthea added a commit that referenced this pull request Nov 24, 2025
    @parthea @gcf-owl-bot
    chore: update templated files (#498)
    a312093 
    * chore: update templated files

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    parthea added a commit that referenced this pull request Nov 24, 2025
    @parthea
    fix: add actionable errors for GCE long running operations (#498)
    72d6b18 
    * fix: add actionable errors for GCE long running operations

* add unit test

* mypy

* add notes that the workaround should be removed once proposal A from b/284179390 is implemented

* fix typo

* fix coverage
    parthea pushed a commit that referenced this pull request Nov 24, 2025
    @gcf-owl-bot
    chore: update dependency protobuf >= 3.20.2 (#498)
    23188df 
    Source-Link: googleapis/synthtool@f58d313
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:7a40313731a7cb1454eef6b33d3446ebb121836738dc3ab3d2d3ded5268c35b6

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    parthea added a commit that referenced this pull request Nov 24, 2025
    @gcf-owl-bot @parthea @daniel-sanche
    feat: Add support for Python 3.12 (#498)
    5c473c7 
    * chore(python): Add Python 3.12

Source-Link: googleapis/synthtool@af16e6d
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bacc3af03bff793a03add584537b36b5644342931ad989e3ba1171d3bd5399f5

* Add python 3.12 to setup.py, constraints and required checks

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Daniel Sanche <sanche@google.com>
    parthea pushed a commit that referenced this pull request Nov 26, 2025
    @arithmetic1728
    test: fix the usage so the tests can pass in g3 (#498)
    4117674 
    * fix: fix the usage so the tests can pass in g3

* use frozenset
    parthea pushed a commit that referenced this pull request Mar 2, 2026
    @gcf-owl-bot
    chore: blacken samples noxfile template (#498)
    d69fe5d
    parthea pushed a commit that referenced this pull request Mar 2, 2026
    @suztomo
    chore: replace old teams with cloud-sdk-python-team and gcs-team (#498)
    7f42050 
    This PR replaces the old yoshi-python team with cloud-sdk-python-team
and cloud-storage-dpe with gcs-team.

b/478003109
    parthea pushed a commit that referenced this pull request Mar 9, 2026
    @olavloite
    fix: support THEN RETURN for insert, update, delete (#503)
    1329f1b 
    * fix: support THEN RETURN for insert, update, delete

Support THEN RETURN clauses for INSERT, UPDATE, and DELETE statements.

Fixes #498

* test: override insert auto-generated pk test
    parthea pushed a commit that referenced this pull request Mar 9, 2026
    @tseaver
    tests: suppress deprecation warnings in unit test output (#499)
    78e6c2b 
    Test hygeine: avoid importing module-under-test at module scope

Closes #498.
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    No one assigned

    Labels

    api: datastore Issues related to the Datastore API.

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    Remove Query dependency on Dataset and make dataset_id required in Query

    3 participants

    @tseaver @dhermes @coveralls
    0