8000 WIP Firestore: replace gax and regenerate gapic by chemelnucfin · Pull Request #4880 · googleapis/google-cloud-python · GitHub
[go: up one dir, main page]
Skip to content
8000

WIP Firestore: replace gax and regenerate gapic#4880

Closed
chemelnucfin wants to merge 2 commits intogoogleapis:masterfrom
chemelnucfin:firestore_regenerate_gapic
Closed

WIP Firestore: replace gax and regenerate gapic#4880
chemelnucfin wants to merge 2 commits intogoogleapis:masterfrom
chemelnucfin:firestore_regenerate_gapic

Conversation

@chemelnucfin
Copy link
Contributor
@chemelnucfin chemelnucfin commented Feb 14, 2018 •
edited by tseaver
Loading

Toward #4692

@jonparrott I haven't ran the tests yet, but something like this?

It looks like it's removed some enums that wasn't replaced. Is that correct behavior?

@chemelnucfin chemelnucfin added api: firestore Issues related to the Firestore API. type: cleanup An internal cleanup or hygiene concern. labels Feb 14, 2018
@chemelnucfin chemelnucfin self-assigned this Feb 14, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 14, 2018
@chemelnucfin chemelnucfin force-pushed the firestore_regenerate_gapic branch from 92752ad to 35445eb Compare February 14, 2018 16:58
@chemelnucfin chemelnucfin force-pushed the firestore_regenerate_gapic branch from 35445eb to 062d2a2 Compare February 14, 2018 17:02
@chemelnucfin chemelnucfin force-pushed the firestore_regenerate_gapic branch from 819209c to 7aa9589 Compare February 15, 2018 02:33
@chemelnucfin
Copy link
Contributor Author
chemelnucfin commented Feb 15, 2018

@jonparrott I have fixed the unit tests, but I haven't figured out what's causing the 504 deadline_exceeded errors in the system tests. There're also some gax stuff in gapic/firestore_admin_client.py that I had to edit manually, which didn't seem right.

I'll probably head back to pubsub again and then come back to this. If you see something obvious that I'm doing wrong, please let me know. thanks.

@chemelnucfin
Copy link
Contributor Author
chemelnucfin commented Feb 15, 2018

I also looked at the config files, but think that the commits should not be idempotent. I did also try to retry the nonidempotent ones with deadline_exceeded though.

@theacodes
Copy link
Contributor
theacodes commented Feb 15, 2018

@chemelnucfin no worries. Thanks for giving this a shot but pubsub is absolutely a higher priority.

@chemelnucfin
Copy link
Contributor Author
chemelnucfin commented Feb 20, 2018

Closing for now

@theacodes theacodes mentioned this pull request Feb 21, 2018
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees

@chemelnucfin chemelnucfin

Labels

api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement. type: cleanup An internal cleanup or hygiene concern.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chemelnucfin @theacodes @googlebot
0