8000 Removing unused code-path for remapping raw gRPC exceptions in datastore. by dhermes · Pull Request #3164 · googleapis/google-cloud-python · GitHub
[go: up one dir, main page]
Skip to content

Removing unused code-path for remapping raw gRPC exceptions in datastore. #3164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dhermes merged 1 commit into from
Mar 20, 2017
Merged

Removing unused code-path for remapping raw gRPC exceptions in datastore. #3164

dhermes merged 1 commit into from
Mar 20, 2017

Conversation

@dhermes
Copy link
Contributor
@dhermes dhermes commented Mar 17, 2017

Follow-up to #2746.

@dhermes dhermes added api: datastore Issues related to the Datastore API. gax grpc labels Mar 17, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 17, 2017
@tseaver
Copy link
Contributor
tseaver commented Mar 20, 2017

@dhermes Do we know for certain that the GAPIC layer can no longer raise GrpcRendezvous errors?
8000

@lukesneeringer
Copy link
Contributor
lukesneeringer commented Mar 20, 2017

Related: googleapis/gax-python#168

@lukesneeringer
Copy link
Contributor
lukesneeringer commented Mar 20, 2017

@dhermes Do we know for certain that the GAPIC layer can no longer raise GrpcRendezvous errors?

If we find a spot where it still does, file a bug in GAX and I will promptly fix it.

@dhermes dhermes merged commit 3bd2493 into googleapis:master Mar 20, 2017
@dhermes dhermes deleted the remove-dead-ds-code branch March 20, 2017 18:29
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@dhermes
Merge pull request googleapis#3164 from dhermes/remove-dead-ds-code
6e81d9a 
Removing unused code-path for remapping raw gRPC exceptions in datastore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lukesneeringer lukesneeringer lukesneeringer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lukesneeringer lukesneeringer

@tseaver tseaver

Labels

api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement. grpc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dhermes @tseaver @lukesneeringer @daspecster @googlebot
0