8000 Fixes #2858 by jmdobry · Pull Request #2859 · googleapis/google-cloud-python · GitHub
[go: up one dir, main page]
Skip to content

Fixes #2858#2859

Merged
dhermes merged 1 commit intogoogleapis:masterfrom
jmdobry:sentence-sentiment
Dec 14, 2016
Merged

Fixes #2858#2859
dhermes merged 1 commit intogoogleapis:masterfrom
jmdobry:sentence-sentiment

Conversation

@jmdobry
Copy link
Contributor
@jmdobry jmdobry commented Dec 12, 2016

Not sure if I did the pydoc stuff right.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 12, 2016
@jmdobry
Copy link
Contributor Author
jmdobry commented Dec 12, 2016

Not sure why the build is failing, but I suspect it's something related to the pydoc (or docstring, or whatever you call it)

daspecster
daspecster reviewed Dec 12, 2016
View reviewed changes
language/google/cloud/language/syntax.py Outdated
document according to the encoding type specified
in the API request.

:type sentiment: :class:`.Sentiment`

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

language/google/cloud/language/syntax.py Outdated
in the API request.

:type sentiment: :class:`.Sentiment`
:param sentiment: For calls to `analyzeSentiment`_ or if

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

language/google/cloud/language/syntax.py Outdated

:type sentiment: :class:`.Sentiment`
:param sentiment: For calls to `analyzeSentiment`_ or if
`include_sentiment` is set to true, this field will

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@daspecster
Copy link
Contributor
daspecster commented Dec 12, 2016

@jmdobry thanks for the PR!

Looks like just one of the Travis issues is from the docstring that I noted in the review.
The rest are issues that were introduced by some Python3 issues. See: #2856.

@jmdobry
Copy link
Contributor Author
jmdobry commented Dec 13, 2016

There's a final line-too-long lint error I'm not sure what to do about.

tseaver
tseaver reviewed Dec 13, 2016
View reviewed changes
language/google/cloud/language/syntax.py Outdated
:param sentiment: For calls to
:func:`~google.cloud.language.document.Document.annotate_text`
where ``include_sentiment`` is set to true, this field
will contain the sentiment for the sentence.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@daspecster
Copy link
Contributor
daspecster commented Dec 13, 2016

Thanks @jmdobry!

@tseaver I think it might be good to squash merge this if it looks good to you.

dhermes
dhermes reviewed Dec 14, 2016
View reviewed changes
language/google/cloud/language/syntax.py Outdated
:type sentiment: :class:`~google.cloud.language.sentiment.Sentiment`
:param sentiment:
For calls to
:func:`~google.cloud.language.document.Document.annotate_text` where

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

language/google/cloud/language/syntax.py Outdated

:type sentiment: :class:`~google.cloud.language.sentiment.Sentiment`
:param sentiment:
For calls to

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

language/google/cloud/language/syntax.py Outdated
"""
text_span = payload['text']
return cls(text_span['content'], text_span['beginOffset'])
sentiment = payload['sentiment'] if 'sentiment' in payload else None

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes
dhermes reviewed Dec 14, 2016
View reviewed changes
language/unit_tests/test_syntax.py
self.assertEqual(sentence.begin, begin)
self.assertEqual(sentence.sentiment, None)

score = 0.5

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes
dhermes reviewed Dec 14, 2016
View reviewed changes
language/unit_tests/test_syntax.py Outdated
self.assertEqual(sentence.begin, begin)

def test_from_api_repr(self):
from google.cloud.language.sentiment import Sentiment

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor
dhermes commented Dec 14, 2016

W:116, 8: Unused variable 'Sentiment' (unused-variable) is the only remaining lint error. w00t

@dhermes dhermes merged commit 6bc1f8b into googleapis:master Dec 14, 2016
@jmdobry jmdobry deleted the sentence-sentiment branch December 14, 2016 20:21
@dhermes dhermes mentioned this pull request Dec 14, 2016
Merged
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@dhermes
Merge pull request googleapis#2859 from jmdobry/sentence-sentiment
d4d52b9 
Fixes googleapis#2858
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@daspecster daspecster daspecster left review comments

@tseaver tseaver tseaver left review comments

@dhermes dhermes dhermes left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jmdobry @daspecster @dhermes @tseaver @googlebot
0