8000 Fix #121: don't copy project ID to the Key protobuf's dataset_id. by tseaver · Pull Request #276 · googleapis/google-cloud-python · GitHub
[go: up one dir, main page]

Skip to content

Fix #121: don't copy project ID to the Key protobuf's dataset_id. #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2014
Merged

Fix #121: don't copy project ID to the Key protobuf's dataset_id. #276

merged 2 commits into from
Oct 22, 2014

Conversation

tseaver
Copy link
Contributor
@tseaver tseaver commented Oct 21, 2014

The back-end already knows it, and it is actually different than the 'project ID' we are assigning to the dataset as its ID.

See #121.

@dhermes
Copy link
Contributor
dhermes commented Oct 21, 2014

I'm going to let @pcostell review as the last time I LGTM'd with hesitation, something broke.

Can you rebase and verify that tox -e regression passes? (I'll clone your fork and do the same.)

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 6e69f41 on tseaver:121-dont_copy_key_datasetid_to_pb into 7f6e4b1 on GoogleCloudPlatform:master.

@silvolu
Copy link
Contributor
silvolu commented Oct 21, 2014

I've just re-run the Travis build because it previously failed for some transient connectivity error, it's green now.

@pcostell
Copy link
Contributor

LGTM. Does the travis build run against a full production Cloud Datastore instance? It would be good to make sure that the dataset really does get populated, just in case.

@dhermes
Copy link
Contributor
dhermes commented Oct 21, 2014

@pcostell it doesn't quite yet, but we are about to add the regression tests to merge.sh which will be run every time a PR is merged.

@tseaver
Copy link
Contributor Author
tseaver commented Oct 21, 2014

@dhermes where is the "how to run regression tests" bit running down? Should maybe be an entry in CONTRIBUTING.rst?

@dhermes
Copy link
Contributor
dhermes commented Oct 21, 2014

Yes, will be in a forthcoming PR.

@tseaver
Copy link
Contributor Author
tseaver commented Oct 22, 2014

6b49d10 makes a further stab at preserving the key's dataset ID as set by the back-end, while not expecting / encouraging it to be set for new keys. It breaks the direct relationship from Key -> Dataset, replacing that with one from Entity -> Dataset.

I've rebased to test with 'tox -e regression': all five pass.

@tseaver tseaver added the api: datastore Issues related to the Datastore API. label Oct 22, 2014
@tseaver tseaver changed the title Fix #121: don't copy key's datset ID to the protobuf. Fix #121: don't copy key's dataset ID to the protobuf. Oct 22, 2014
The back-end already knows it, and it is actually different than the
'project ID' we are assigning to the dataset as its ID.

Fixes #121.
Replace it with an (optional) '_dataset_id' attribute, which is None for
newly-created keys, or the more-or-less opaque value set by the backend
for keys fetched from it.

Add direct 'Entity' -> 'Dataset' relationship (rather than indirecting
through the entity's key.

Addresses @pcostell's remarks on #259:

#259 (comment)
@tseaver
Copy link
Contributor Author
tseaver commented Oct 22, 2014

Rebased after merging #284 to master.

@tseaver tseaver changed the title Fix #121: don't copy key's dataset ID to the protobuf. Fix #121: don't copy project ID to the Key protobuf's dataset_id. Oct 22, 2014
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling c769cc7 on tseaver:121-dont_copy_key_datasetid_to_pb into c2a38fb on GoogleCloudPlatform:master.

silvolu added a commit that referenced this pull request Oct 22, 2014
Fix #121: don't copy project ID to the Key protobuf's dataset_id.
@silvolu silvolu merged commit fe6e4fb into googleapis:master Oct 22, 2014
@tseaver tseaver deleted the 121-dont_copy_key_datasetid_to_pb branch October 22, 2014 19:32
atulep pushed a commit that referenced this pull request Apr 6, 2023
…276)

* docs(samples): a draft that refactors speech_to_storage_beta sample

* docs(samples): applied changes

* docs(samples): file name changed

* docs(samples): added new line eof

* docs(samples): updated to LongRunningRecognizeResponse

* docs(samples): fixed lint

* docs(samples): removed unwanted line

* docs(samples): removed unwanted line
atulep pushed a commit that referenced this pull request Apr 6, 2023
…276)

* docs(samples): a draft that refactors speech_to_storage_beta sample

* docs(samples): applied changes

* docs(samples): file name changed

* docs(samples): added new line eof

* docs(samples): updated to LongRunningRecognizeResponse

* docs(samples): fixed lint

* docs(samples): removed unwanted line

* docs(samples): removed unwanted line
atulep pushed a commit that referenced this pull request Apr 18, 2023
…276)

* docs(samples): a draft that refactors speech_to_storage_beta sample

* docs(samples): applied changes

* docs(samples): file name changed

* docs(samples): added new line eof

* docs(samples): updated to LongRunningRecognizeResponse

* docs(samples): fixed lint

* docs(samples): removed unwanted line

* docs(samples): removed unwanted line
parthea pushed a commit that referenced this pull request Jun 4, 2023
Source-Link: https://togithub.com/googleapis/synthtool/commit/92006bb3cdc84677aa93c7f5235424ec2b157146
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6
parthea pushed a commit that referenced this pull request Jun 4, 2023
parthea added a commit that referenced this pull request Jun 4, 2023
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit that referenced this pull request Jun 4, 2023
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
Source-Link: googleapis/synthtool@50db768
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e09366bdf0fd9c8976592988390b24d53583dd9f002d476934da43725adbb978
parthea pushed a commit that referenced this pull request Jun 4, 2023
Source-Link: https://togithub.com/googleapis/synthtool/commit/d0f51a0c2a9a6bcca86911eabea9e484baadf64b
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:240b5bcc2bafd450912d2da2be15e62bc6de2cf839823ae4bf94d4f392b451dc
parthea added a commit that referenced this pull request Jun 4, 2023
* docs(samples): init add mute config samples

* docs(samples): added test for mute config samples

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* docs(samples): lint fix

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* docs(samples): lint fix

* docs(samples): applied documentation review comments

* docs(samples): applied documentation review comments

* lint fix

* docs(samples): fixed syntax typo

* docs(samples): modified create finding method

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* remove unused import

* docs(samples): fixed finding path and return mismatch

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: fix finding path

* docs(samples): fix finding yield param

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* minor test output fix

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Bu Sun Kim <busunkim@google.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
Source-Link: googleapis/synthtool@7ff4aad
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:462782b0b492346b2d9099aaff52206dd30bc8e031ea97082e6facecc2373244
parthea pushed a commit that referenced this pull request Jul 6, 2023
Source-Link: googleapis/synthtool@38e11ad
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:4e1991042fe54b991db9ca17c8fb386e61b22fe4d1472a568bf0fcac85dcf5d3
parthea pushed a commit that referenced this pull request Aug 15, 2023
- [ ] Regenerate this pull request now.

feat: added data format specification for export agent

PiperOrigin-RevId: 437338899

Source-Link: googleapis/googleapis@94287f4

Source-Link: googleapis/googleapis-gen@c0bb2ea
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzBiYjJlYTA3MjI0NWIwNzMxYTlmMjA4YWU2NDA4MmRlMDczZjIzOCJ9
parthea pushed a commit that referenced this pull request Sep 20, 2023
Source-Link: https://togithub.com/googleapis/synthtool/commit/26c7505b2f76981ec1707b851e1595c8c06e90fc
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f946c75373c2b0040e8e318c5e85d0cf46bc6e61d0a01f3ef94d8de974ac6790
parthea added a commit that referenced this pull request Sep 22, 2023
* fix(deps): Require google-api-core >=1.34.0, >=2.11.0

fix: Drop usage of pkg_resources

fix: Fix timeout default values

docs(samples): Snippetgen should call await on the operation coroutine before calling result

PiperOrigin-RevId: 493260409

Source-Link: googleapis/googleapis@fea4387

Source-Link: googleapis/googleapis-gen@387b734
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzg3YjczNDRjNzUyOWVlNDRiZTg0ZTYxM2IxOWE4MjA1MDhjNjEyYiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* add gapic_version.py

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
parthea added a commit that referenced this pull request Sep 22, 2023
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit that referenced this pull request Sep 22, 2023
* chore(deps): update all dependencies to v2.11.1

* revert

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit that referenced this pull request Sep 22, 2023
* chore: delete owlbot.py

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
Source-Link: googleapis/synthtool@c4dd595
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ce3c1686bc81145c81dd269bd12c4025c6b275b22d14641358827334fddb1d72
parthea added a commit that referenced this pull request Sep 22, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
)

Source-Link: googleapis/synthtool@7804ade
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:eede5672562a32821444a8e803fb984a6f61f2237ea3de229d2de24453f4ae7d

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
Improving the code snippets for disk snapshots, so they can be used on this page: [Create and manage disk snapshots
](https://cloud.google.com/compute/docs/disks/create-snapshots)
parthea pushed a commit that referenced this pull request Oct 21, 2023
Source-Link: googleapis/synthtool@35e1ea8
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:73564f768388926a050a7a957650bfd1f584df6e0b3512e199a8e12d9dfc4618

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Oct 21, 2023
* chore: use gapic-generator-python 0.63.2
docs: add generated snippets

PiperOrigin-RevId: 427792504

Source-Link: googleapis/googleapis@55b9e1e

Source-Link: googleapis/googleapis-gen@bf4e86b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYmY0ZTg2Yjc1M2Y0MmNiMGVkYjFmZDUxZmJlODQwZDdkYTBhMWNkZSJ9

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: use gapic-generator-python 0.63.4

chore: fix snippet region tag format
chore: fix docstring code block formatting
PiperOrigin-RevId: 430730865

Source-Link: googleapis/googleapis@ea58002

Source-Link: googleapis/googleapis-gen@ca893ff
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2E4OTNmZjhhZjI1ZmM3ZmUwMDFkZTE0MDVhNTE3ZDgwNDQ2ZWNjYSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: delete duplicates

* restore async_client.py

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 403140062

Source-Link: googleapis/googleapis@67e6e0a

Source-Link: googleapis/googleapis-gen@779ead9
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzc5ZWFkOTJjZGMyNDMzZDg0YWU1YWU1MzQxOGIxNjAwODQzMjI0ZSJ9
parthea pushed a commit that referenced this pull request Oct 21, 2023
* feat: release SensitiveAction Cloud Logging payload to v1

PiperOrigin-RevId: 476083958

Source-Link: googleapis/googleapis@fafd03f

Source-Link: googleapis/googleapis-gen@79c1b9c
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzljMWI5Y2UyNDMzNzQ3MzU2NTFlNzJjZGViY2JlZDk5ZjVlNGU2NSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
Source-Link: googleapis/synthtool@c4dd595
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ce3c1686bc81145c81dd269bd12c4025c6b275b22d14641358827334fddb1d72
parthea pushed a commit that referenced this pull request Oct 21, 2023
…276)

Source-Link: googleapis/synthtool@6b4d5a6
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f792ee1320e03eda2d13a5281a2989f7ed8a9e50b73ef6da97fac7e1e850b149

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
…276)

* docs(samples): a draft that refactors speech_to_storage_beta sample

* docs(samples): applied changes

* docs(samples): file name changed

* docs(samples): added new line eof

* docs(samples): updated to LongRunningRecognizeResponse

* docs(samples): fixed lint

* docs(samples): removed unwanted line

* docs(samples): removed unwanted line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the Datastore API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0