8000 Beginning of HappyBase batch module. by dhermes · Pull Request #1515 · googleapis/google-cloud-python · GitHub
[go: up one dir, main page]
Skip to content

Beginning of HappyBase batch module. #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2016
Merged

Beginning of HappyBase batch module. #1515

merged 1 commit into from
Feb 23, 2016

Conversation

dhermes
Copy link
Contributor
@dhermes dhermes commented Feb 21, 2016

@dhermes dhermes added the api: bigtable Issues related to the Bigtable API. label Feb 21, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 21, 2016
@tseaver tseaver mentioned this pull request Feb 22, 2016
Merged
@dhermes dhermes assigned theacodes and unassigned tseaver Feb 22, 2016
@theacodes
Copy link
Contributor

LGTM with minor readability nit.

(as an aside, I really hate unittest2's testing style)

theacodes
theacodes reviewed Feb 23, 2016
View reviewed changes
gcloud/bigtable/happybase/batch.py
self._batch_size = batch_size
# Timestamp is in milliseconds, convert to microseconds.
self._timestamp = self._delete_range = None
if timestamp is not None:

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor Author
dhermes commented Feb 23, 2016

@jonparrott unittest2 is just a back-port of unittest, so there is no testing style to speak of. We do things guided by some notes from @tseaver.

@dhermes dhermes force-pushed the begin-happybase-batch branch from faf442d to bfc56f2 Compare February 23, 2016 20:25
dhermes added a commit that referenced this pull request Feb 23, 2016
@dhermes
Merge pull request #1515 from dhermes/begin-happybase-batch
115263b 
Beginning of HappyBase batch module.
@dhermes dhermes merged commit 115263b into googleapis:master Feb 23, 2016
@dhermes dhermes deleted the begin-happybase-batch branch February 23, 2016 20:29
@theacodes theacodes mentioned this pull request Mar 4, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@theacodes theacodes

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes @theacodes @tseaver @googlebot
0