8000 Rename suppressed pylint error to match value expected by 1.5.4. by tseaver · Pull Request #1468 · googleapis/google-cloud-python · GitHub
[go: up one dir, main page]
Skip to content

Rename suppressed pylint error to match value expected by 1.5.4. #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2016
Merged

Rename suppressed pylint error to match value expected by 1.5.4. #1468

merged 1 commit into from
Feb 15, 2016

Conversation

tseaver
Copy link
Contributor
@tseaver tseaver commented Feb 15, 2016

Suppresses output from pylint 1.5.4 like:

lint runtests: commands[1] | python /home/tseaver/projects/agendaless/Google/src/gcloud-python/scripts/run_pylint.py
Diff base not specified, listing all files in repository.
************* Module gcloud._helpers
I: 28, 0: Locally disabling import-error (E0401) (locally-disabled)
I: 90, 0: Locally disabling unused-argument (W0613) (locally-disabled)
I:100, 0: Locally disabling unused-argument (W0613) (locally-disabled)
I:104, 0: Locally disabling unused-argument (W0613) (locally-disabled)
I:392, 0: Locally disabling unused-import (W0611) (locally-disabled)
I:392, 0: Locally disabling wrong-import-position (C0413) (locally-disabled)
C:392, 4: external import "from pytz import UTC" comes before "from gcloud.environment_vars import PROJECT" (wrong-import-order)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 15, 2016
@dhermes
Copy link
Contributor
dhermes commented Feb 15, 2016

@tseaver Thanks for the fix. I tried to reproduce locally and cannot. What libraries do I need to update to see this error? (I already created brand new tox environments on multiple machines.)

@tseaver
Copy link
Contributor Author
tseaver commented Feb 15, 2016

I tried to reproduce locally and cannot

I found it after tox -r failed on that output. I have no idea why mine would fail and not your (or Travis).

@tseaver tseaver mentioned this pull request Feb 15, 2016
Merged
@dhermes
Copy link
Contributor
dhermes commented Feb 15, 2016

LGTM BTW

@tseaver
Copy link
Contributor Author
tseaver commented Feb 15, 2016

Here is a Travis failure:

https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/109433029

tseaver added a commit that referenced this pull request Feb 15, 2016
@tseaver
Merge pull request #1468 from tseaver/suppress-pylint-1.5.4-error
6337db6 
Rename suppressed pylint error to match value expected by 1.5.4.
@tseaver tseaver merged commit 6337db6 into googleapis:master Feb 15, 2016
@tseaver tseaver deleted the suppress-pylint-1.5.4-error branch February 15, 2016 20:25
@dhermes
Copy link
Contributor
dhermes commented Feb 15, 2016

Yeah I re-ran the main build 3 times because I couldn't repro and was trying to see if it was intermittent

@dhermes dhermes mentioned this pull request Feb 17, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot
0