8000 Adding helper to convert protobuf GC rules into our types. by dhermes · Pull Request #1305 · googleapis/google-cloud-python · GitHub
[go: up one dir, main page]
Skip to content

Adding helper to convert protobuf GC rules into our types. #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2015
Merged

Adding helper to convert protobuf GC rules into our types. #1305

merged 1 commit into from
Dec 18, 2015

Conversation

dhermes
Copy link
Contributor
@dhermes dhermes commented Dec 17, 2015

No description provided.

@dhermes dhermes added the api: bigtable Issues related to the Bigtable API. label Dec 17, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 17, 2015
@tseaver
Copy link
Contributor
tseaver commented Dec 18, 2015

LGTM. "Marshalling is such sweet sorrow."

@dhermes
Copy link
Contributor Author
dhermes commented Dec 18, 2015

Ha! Now we can finally build something non-trivial inside of a table.

dhermes added a commit that referenced this pull request Dec 18, 2015
@dhermes
Merge pull request #1305 from dhermes/bigtable-convert-gc-rule
8315501 
Adding helper to convert protobuf GC rules into our types.
@dhermes dhermes merged commit 8315501 into googleapis:master Dec 18, 2015
@dhermes dhermes deleted the bigtable-convert-gc-rule branch December 18, 2015 21:40
@dhermes dhermes mentioned this pull request Jan 25, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhermes @tseaver @googlebot
0