8000 feat(core): change default api_request() timeout to non-None by plamut · Pull Request #10219 · googleapis/google-cloud-python · GitHub
[go: up one dir, main page]
Skip to content

feat(core): change default api_request() timeout to non-None #10219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2020
Merged

feat(core): change default api_request() timeout to non-None #10219

merged 1 commit into from
Jan 29, 2020

Conversation

plamut
Copy link
Contributor
@plamut plamut commented Jan 28, 2020 •
edited
Loading

Closes #10217.

As discussed - we want to have a non-None default timeout, but still allow overriding it with None if somebody wants so.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut requested a review from crwilcox January 28, 2020 19:05
@plamut plamut requested a review from busunkim96 as a code owner January 28, 2020 19:05
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 28, 2020
@plamut plamut merged commit 9ad21f4 into googleapis:master Jan 29, 2020
@plamut plamut deleted the iss-10217 branch January 29, 2020 07:21
@plamut plamut mentioned this pull request Jan 29, 2020
Closed
This was referenced Jan 29, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@HemangChothani HemangChothani mentioned this pull request Jan 30, 2020
Closed
This was referenced Jan 30, 2020
Closed
Closed
@yoshi-automation yoshi-automation mentioned this pull request Feb 7, 2020
Closed
This was referenced Feb 7, 2020
Closed
Closed
@tswast tswast mentioned this pull request Aug 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

1 more reviewer

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: core cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Core: change the default timeout of JSONConnection.api_request() to non-None

3 participants

@plamut @busunkim96 @googlebot
0