8000 fix(dns): update test assertion and core version pins by plamut · Pull Request #10096 · googleapis/google-cloud-python · GitHub
[go: up one dir, main page]

Skip to content

Conversation

plamut
Copy link
Contributor
@plamut plamut commented Jan 10, 2020

Towards #10088.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pa 8000 ss
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Version bump is needed, as timeouts were introduced to API core.
@plamut plamut added the api: dns Issues related to the Cloud DNS API. label Jan 10, 2020
@plamut plamut requested a review from busunkim96 as a code owner January 10, 2020 15:51
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 10, 2020
@plamut plamut merged commit 561dced into googleapis:master Jan 10, 2020
@plamut plamut deleted the fix-tests-dns branch January 10, 2020 17:57
This was referenced Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: dns Issues related to the Cloud DNS API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0