8000 Unblock UBLA/BPO test by JesseLovelace · Pull Request #6987 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@JesseLovelace
Copy link
Contributor
@JesseLovelace JesseLovelace commented Dec 4, 2019

Enabling BPO/UBLA now requires ACL fields to be clear. A bug existed in production that ignored ACL when enabling BPO/UBLA with ACL fields being set.

@JesseLovelace JesseLovelace requested a review from frankyn December 4, 2019 21:30
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 4, 2019
Copy link
Contributor
@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending tests, otherwise LGTM.

@codecov
Copy link
codecov bot commented Dec 4, 2019

Codecov Report

Merging #6987 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6987   +/-   ##
=========================================
  Coverage     39.08%   39.08%           
  Complexity     5001     5001           
=========================================
  Files           339      339           
  Lines         47762    47762           
  Branches       6789     6789           
=========================================
  Hits          18670    18670           
  Misses        27678    27678           
  Partials       1414     1414

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b10869...412432c. Read the comment docs.

@frankyn frankyn merged commit 26415a1 into master Dec 4, 2019
@frankyn frankyn deleted the fixublatests branch December 4, 2019 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0