E529 Extract Pub/Sub client by chingor13 · Pull Request #6960 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Extract Pub/Sub client #6960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 1 commit into from
Dec 2, 2019
Merged

Extract Pub/Sub client #6960

chingor13 merged 1 commit into from
Dec 2, 2019

Conversation

@chingor13
Copy link
Contributor
8000
@chingor13 chingor13 commented Dec 2, 2019

No description provided.

@chingor13 chingor13 requested a review from a team December 2, 2019 17:34
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 2, 2019
@codecov
Copy link
codecov bot commented Dec 2, 2019 •
edited
Loading

Codecov Report

Merging #6960 into master will decrease coverage by 2.1%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6960      +/-   ##
============================================
- Coverage     41.05%   38.94%   -2.11%     
+ Complexity     5290     4980     -310     
============================================
  Files           360      339      -21     
  Lines         50413    47739    -2674     
  Branches       6913     6784     -129     
============================================
- Hits          20695    18593    -2102     
+ Misses        28243    27740     -503     
+ Partials       1475     1406      -69
Impacted Files Coverage Δ Complexity Δ
...oogle/cloud/spanner/jdbc/SingleUseTransaction.java 86% <0%> (-1%) 36% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e2d497...73f952d. Read the comment docs.

@chingor13 chingor13 merged commit 38760cb into googleapis:master Dec 2, 2019
@chingor13 chingor13 deleted the extract-pubsub branch December 2, 2019 18:32
This was referenced Dec 4, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codyoss codyoss codyoss approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chingor13 @codyoss @googlebot
0