8000 spanner-jdbc: Filter unwanted files from META-INF directory by olavloite · Pull Request #6956 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

spanner-jdbc: Filter unwanted files from META-INF directory #6956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skuruppu merged 1 commit into from
Dec 5, 2019
Merged

spanner-jdbc: Filter unwanted files from META-INF directory #6956

skuruppu merged 1 commit into from
Dec 5, 2019

Conversation

@olavloite
Copy link
@olavloite olavloite commented Nov 30, 2019

The build profile for the shaded JDBC jar includes a number of files that should not be included in the META-INF directory. The files are automatically included from other jars but are not valid for the JDBC jar. This change filters these out during the build process.

Updates #6950

@olavloite olavloite requested a review from skuruppu November 30, 2019 18:34
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 30, 2019
@codecov
Copy link
codecov bot commented Nov 30, 2019

Codecov Report

Merging #6956 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6956      +/-   ##
============================================
- Coverage     41.05%   41.04%   -0.01%     
+ Complexity     5290     5289       -1     
============================================
  Files           360      360              
  Lines         50413    50413              
  Branches       6913     6913              
============================================
- Hits          20695    20692       -3     
- Misses        28243    28244       +1     
- Partials       1475     1477       +2
Impacted Files Coverage Δ Complexity Δ
...oogle/cloud/spanner/jdbc/SingleUseTransaction.java 86% <0%> (-1%) 36% <0%> (-1%)
.../com/google/cloud/pubsub/v1/MessageDispatcher.java 84.61% <0%> (-0.52%) 23% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e2d497...62f64b5. Read the comment docs.

@skuruppu skuruppu merged commit e90e7a6 into googleapis:master Dec 5, 2019
@kolea2 kolea2 mentioned this pull request Dec 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@skuruppu skuruppu skuruppu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@olavloite @skuruppu @googlebot
0