8000 chore: remove utilities that are unnecessary with the split repo by chingor13 · Pull Request #6896 · googleapis/google-cloud-java · GitHub 8000
[go: up one dir, main page]
Skip to content

chore: remove utilities that are unnecessary with the split repo #6896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 1 commit into from
Nov 25, 2019
Merged

chore: remove utilities that are unnecessary with the split repo #6896

chingor13 merged 1 commit into from
Nov 25, 2019

Conversation

@chingor13
Copy link
Contributor
@chingor13 chingor13 commented Nov 25, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 25, 2019
@chingor13 chingor13 requested a review from a team November 25, 2019 22:47
@chingor13 chingor13 mentioned this pull request Nov 25, 2019
Closed
@codecov
Copy link
codecov bot commented Nov 25, 2019 •
edited
Loading

Codecov Report

Merging #6896 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6896      +/-   ##
============================================
+ Coverage      45.2%   45.27%   +0.07%     
  Complexity     6249     6249              
============================================
  Files           453      453              
  Lines         56165    56280     +115     
  Branches       7147     7229      +82     
============================================
+ Hits          25388    25482      +94     
- Misses        29065    29141      +76     
+ Partials       1712     1657      -55
Impacted Files Coverage Δ Complexity Δ
...le/cloud/storage/contrib/nio/CloudStoragePath.java 75.67% <0%> (-0.69%) 51% <0%> (ø)
...ge/contrib/nio/CloudStorageFileSystemProvider.java 62.76% <0%> (-0.3%) 73% <0%> (ø)
...ain/java/com/google/cloud/storage/StorageImpl.java 76.72% <0%> (-0.16%) 108% <0%> (ø)
...m/google/cloud/spanner/jdbc/JdbcTypeConverter.java 74.86% <0%> (-0.14%) 88% <0%> (ø)
...oogle/cloud/spanner/jdbc/JdbcDatabaseMetaData.java 87.67% <0%> (-0.13%) 165% <0%> (ø)
...src/main/java/io/grafeas/v1/UpdateNoteRequest.java 11.74% <0%> (-0.08%) 11% <0%> (ø)
...in/java/io/grafeas/v1/UpdateOccurrenceRequest.java 11.71% < 8000 ;0%> (-0.08%) 11% <0%> (ø)
...ava/io/grafeas/v1/ListNoteOccurrencesResponse.java 14.28% <0%> (-0.05%) 10% <0%> (ø)
...a/io/grafeas/v1/BatchCreateOccurrencesRequest.java 14.28% <0%> (-0.05%) 10% <0%> (ø)
...in/java/io/grafeas/v1/ListOccurrencesResponse.java 14.28% <0%> (-0.05%) 10% <0%> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 005a8e3...ab36170. Read the comment docs.

@chingor13 chingor13 merged commit 4d22e42 into googleapis:master Nov 25, 2019
@chingor13 chingor13 deleted the remove-utilities branch November 25, 2019 23:07
This was referenced Dec 4, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@BenWhitehead BenWhitehead BenWhitehead approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chingor13 @BenWhitehead @googlebot
0