Add toString() method to LifecycleRule #6856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cloud-java into lifecycleruletostring
…cloud-java into lifecycleruletostring
…cloud-java into lifecycleruletostring
Codecov Report
@@ Coverage Diff @@
## master #6856 +/- ##
============================================
- Coverage 46.37% 46.37% -0.01%
Complexity 28028 28028
============================================
Files 2615 2615
Lines 288309 288325 +16
Branches 33809 33809
============================================
Hits 133709 133709
- Misses 144334 144350 +16
Partials 10266 10266
Continue to review full report at Codecov.
|
frankyn
reviewed
Nov 21, 2019
| @Override | ||
| public String toString() { | ||
| return MoreObjects.toStringHelper(this) | ||
| .add("action", lifecycleAction.getActionType()) |
Contributor
There was a problem hiding this comment.
Could you do a toString() for ActionType? It's missing setStorageClass information in this case.
…cloud-java into lifecycleruletostring
…cloud-java into lifecycleruletostring
frankyn
approved these changes
Nov 22, 2019
Contributor
There was a problem hiding this comment.
LGTM, thanks @JesseLovelace!
This was referenced Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds toString() method to LifecycleRule