8000 chore: extract Bigtable to https://github.com/googleapis/java-bigtable by kolea2 · Pull Request #6801 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

chore: extract Bigtable to https://github.com/googleapis/java-bigtable #6801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 2 commits into from
Nov 25, 2019
Merged

chore: extract Bigtable to https://github.com/googleapis/java-bigtable #6801

chingor13 merged 2 commits into from
Nov 25, 2019
+14 −157,707

Conversation

@kolea2
Copy link
Contributor
@kolea2 kolea2 commented Nov 18, 2019

Also fixes #6686

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 18, 2019
igorbernstein2
igorbernstein2 approved these changes Nov 18, 2019
View reviewed changes
Copy link
@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@codecov
Copy link
codecov bot commented Nov 25, 2019

Codecov Report

Merging #6801 into master will increase coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #6801       +/-   ##
=============================================
+ Coverage     45.27%   45.64%    +0.36%     
- Complexity     6249    27067    +20818     
=============================================
  Files           453     2522     +2069     
  Lines         56280   282440   +226160     
  Branches       7229    33493    +26264     
=============================================
+ Hits          25481   128916   +103435     
- Misses        29141   143440   +114299     
- Partials       1658    10084     +8426
Impacted Files Coverage Δ Complexity Δ
...b/GrpcAutoscalingPolicyServiceCallableFactory.java 37.5% <0%> (ø) 3% <0%> (?)
...loud/vision/v1p1beta1/stub/ImageAnnotatorStub.java 50% <0%> (ø) 1% <0%> (?)
.../cloud/dialogflow/v2/SessionEntityTypesClient.java 59.78% <0%> (ø) 23% <0%> (?)
...ta2/stub/GrpcClusterControllerCallableFactory.java 50% <0%> (ø) 4% <0%> (?)
...eta2/stub/WorkflowTemplateServiceStubSettings.java 83.96% <0%> (ø) 19% <0%> (?)
...ogle/cloud/compute/v1/RegionInstanceGroupList.java 31.25% <0%> (ø) 8% <0%> (?)
...e/cloud/compute/v1/ListSubnetworksHttpRequest.java 24.33% <0%> (ø) 11% <0%> (?)
...le/cloud/compute/v1/stub/NodeTypeStubSettings.java 75.53% <0%> (ø) 13% <0%> (?)
...gle/cloud/compute/v1/MetadataFilterLabelMatch.java 0% <0%> (ø) 0% <0%> (?)
.../com/google/cloud/compute/v1/NodeTypeSettings.java 23.52% <0%> (ø) 3% <0%> (?)
... and 2155 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 005a8e3...53bc00f. Read the comment docs.

@chingor13 chingor13 merged commit 06cd90a into googleapis:master Nov 25, 2019
This was referenced Dec 4, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 approved these changes

+1 more reviewer

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cleanup bigtable remnants after repo split

4 participants

@kolea2 @chingor13 @igorbernstein2 @googlebot
0