8000 Fix versions by elharo · Pull Request #6794 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Fix versions #6794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
elharo merged 3 commits into from
Nov 25, 2019
Merged

Fix versions #6794

elharo merged 3 commits into from
Nov 25, 2019

Conversation

@elharo
Copy link
Contributor
@elharo elharo commented Nov 15, 2019

@elharo elharo requested a review from athakor November 15, 2019 11:51
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 15, 2019
@elharo
Copy link
Contributor Author
elharo commented Nov 15, 2019

Failure looks flaky but we might want to figure it out anyway:

[ERROR] Tests run: 6, Failures: 1, Errors: 1, Skipped: 0, Time elapsed: 19.218 s <<< FAILURE! - in com.google.cloud.bigtable.admin.v2.it.BigtableInstanceAdminClientIT
[ERROR] clusterCreationDeletionTest(com.google.cloud.bigtable.admin.v2.it.BigtableInstanceAdminClientIT)  Time elapsed: 2.253 s  <<< ERROR!
com.google.api.gax.rpc.InvalidArgumentException: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Cluster storage types must match. Requested: SSD Existing: HDD
	at com.google.api.gax.rpc.ApiExceptionFactory.createException(ApiExceptionFactory.java:49)
	at com.google.api.gax.grpc.GrpcApiExceptionFactory.create(GrpcApiExceptionFactory.java:72)
	at com.google.api.gax.grpc.GrpcApiExceptionFactory.create(GrpcApiExceptionFactory.java:60)
	at com.google.api.gax.grpc.GrpcExceptionCallable$ExceptionTransformingFuture.onFailure(GrpcExceptionCallable.java:97)
	at com.google.api.core.ApiFutures$1.onFailure(ApiFutures.java:68)
	at com.google.common.util.concurrent.Futures$CallbackListener.run(Futures.java:982)
	at com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:30)
	at com.google.common.util.concurrent.AbstractFuture.executeListener(AbstractFuture.java:1138)
	at com.google.common.util.concurrent.AbstractFuture.complete(AbstractFuture.java:957)
	at com.google.common.util.concurrent.AbstractFuture.setException(AbstractFuture.java:748)
	at io.grpc.stub.ClientCalls$GrpcFuture.setException(ClientCalls.java:515)
	at io.grpc.stub.ClientCalls$UnaryStreamToFuture.onClose(ClientCalls.java:490)
	at io.grpc.PartialForwardingClientCallListener.onClose(PartialForwardingClientCallListener.java:39)
	at io.grpc.ForwardingClientCallListener.onClose(ForwardingClientCallListener.java:23)
	at io.grpc.ForwardingClientCallListener$SimpleForwardingClientCallListener.onClose(ForwardingClientCallListener.java:40)
	at io.grpc.internal.CensusStatsModule$StatsClientInterceptor$1$1.onClose(CensusStatsModule.java:700)
	at io.grpc.PartialForwardingClientCallListener.onClose(PartialForwardingClientCallListener.java:39)
	at io.grpc.ForwardingClientCallListener.onClose(ForwardingClientCallListener.java:23)
	at io.grpc.ForwardingClientCallListener$SimpleForwardingClientCallListener.onClose(ForwardingClientCallListener.java:40)
	at io.grpc.internal.CensusTracingModule$TracingClientInterceptor$1$1.onClose(CensusTracingModule.java:399)
	at io.grpc.internal.ClientCallImpl.closeObserver(ClientCallImpl.java:510)
	at io.grpc.internal.ClientCallImpl.access$300(ClientCallImpl.java:66)
	at io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl.close(ClientCallImpl.java:630)
	at io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl.access$700(ClientCallImpl.java:518)
	at io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl$1StreamClosed.runInternal(ClientCallImpl.java:692)
	at io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl$1StreamClosed.runInContext(ClientCallImpl.java:681)
	at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
	at io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:123)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
	Suppressed: com.google.api.gax.rpc.AsyncTaskException: Asynchronous task failed
		at com.google.api.gax.rpc.ApiExceptions.callAndTranslateApiException(ApiExceptions.java:57)
		at com.google.cloud.bigtable.admin.v2.BigtableInstanceAdminClient.createCluster(BigtableInstanceAdminClient.java:500)
		at com.google.cloud.bigtable.admin.v2.it.BigtableInstanceAdminClientIT.clusterCreationDeletionTest(BigtableInstanceAdminClientIT.java:155)
		at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
		at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
		at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
		at java.lang.reflect.Method.invoke(Method.java:498)
		at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
		at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
		at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
		at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
		at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
		at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
		at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
		at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
		at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
		at org.apache.maven.surefire.junitcore.pc.Scheduler$1.run(Scheduler.java:405)
		at org.apache.maven.surefire.junitcore.pc.InvokerStrategy.schedule(InvokerStrategy.java:54)
		at org.apache.maven.surefire.junitcore.pc.Scheduler.schedule(Scheduler.java:362)
		at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
		at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
		at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
		at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
		at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
		at org.junit.rules.RunRules.evaluate(RunRules.java:20)
		at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
		at org.junit.runners.Suite.runChild(Suite.java:128)
		at org.junit.runners.Suite.runChild(Suite.java:27)
		at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
		at org.apache.maven.surefire.junitcore.pc.Scheduler$1.run(Scheduler.java:405)
		at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
		at java.util.concurrent.FutureTask.run(FutureTask.java:266)
		... 3 more
Caused by: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Cluster storage types must match. Requested: SSD Existing: HDD
	at io.grpc.Status.asRuntimeException(Status.java:533)
	... 24 more

[ERROR] basicClusterOperationTest(com.google.cloud.bigtable.admin.v2.it.BigtableInstanceAdminClientIT)  Time elapsed: 5.889 s  <<< FAILURE!
expected: 3
but was : com.google.cloud.bigtable.admin.v2.models.Cluster@dd6402ed
	at com.google.cloud.bigtable.admin.v2
8000
.it.BigtableInstanceAdminClientIT.basicClusterOperationTest(BigtableInstanceAdminClientIT.java:206)

[INFO]
[INFO] Results:

@elharo elharo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2019
elharo
elharo commented Nov 21, 2019
View reviewed changes
Copy link
Contributor Author
@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping

athakor
athakor reviewed Nov 21, 2019
View reviewed changes
google-cloud-clients/google-cloud-bigtable/README.md
If you are using SBT, add this to your dependencies
```Scala
libraryDependencies += "com.google.cloud" % "google-cloud-bigtable" % "1.5.0"
libraryDependencies += "com.google.cloud" % "google-cloud-bigtable" % "1.6.0"
Copy link
8000 Contributor
@athakor athakor Nov 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update bigtable version for groovy as well.

Copy link
Contributor Author
@elharo elharo Nov 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@codecov
Copy link
codecov bot commented Nov 25, 2019

Codecov Report

Merging #6794 into master will decrease coverage by 9.23%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #6794       +/-   ##
=============================================
- Coverage      55.6%   46.37%    -9.24%     
- Complexity    10554    28044    +17490     
=============================================
  Files           774     2615     +1841     
  Lines         88532   288309   +199777     
  Branches       8080    33804    +25724     
=============================================
+ Hits          49231   133709    +84478     
- Misses        37081   144334   +107253     
- Partials       2220    10266     +8046
Impacted Files Coverage Δ Complexity Δ
.../com/google/cloud/pubsub/v1/MessageDispatcher.java 84.61% <0%> (-0.52%) 23% <0%> (ø)
...loud/vision/v1p1beta1/stub/ImageAnnotatorStub.java 50% <0%> (ø) 1% <0%> (?)
.../cloud/dialogflow/v2/SessionEntityTypesClient.java 59.78% <0%> (ø) 23% <0%> (?)
...ogflow/v2/stub/SessionEntityTypesStubSettings.java 79.41% <0%> (ø) 15% <0%> (?)
...ogle/cloud/compute/v1/RegionInstanceGroupList.java 31.25% <0%> (ø) 8% <0%> (?)
...e/cloud/compute/v1/ListSubnetworksHttpRequest.java 24.33% <0%> (ø) 11% <0%> (?)
...le/cloud/compute/v1/stub/NodeTypeStubSettings.java 75.53% <0%> (ø) 13% <0%> (?)
...gle/cloud/compute/v1/MetadataFilterLabelMatch.java 0% <0%> (ø) 0% <0%> (?)
.../com/google/cloud/compute/v1/NodeTypeSettings.java 23.52% <0%> (ø) 3% <0%> (?)
...ogle/cloud/compute/v1/GlobalOperationSettings.java 21.62% <0%> (ø) 3% <0%> (?)
... and 1833 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8acde5d...e76475b. Read the comment docs.

@elharo elharo merged commit 3e3de0d into master Nov 25, 2019
@elharo elharo deleted the elharo-patch-7 branch November 25, 2019 21:08
This was referenced Dec 4, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@athakor athakor athakor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@elharo @athakor @googlebot @yoshi-kokoro
0