8000 Storage : Updating docstring of withHostName by athakor · Pull Request #6788 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Storage : Updating docstring of withHostName #6788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
athakor merged 1 commit into from
Nov 14, 2019
Merged

Storage : Updating docstring of withHostName #6788

athakor merged 1 commit into from
Nov 14, 2019

Conversation

@athakor
Copy link
Contributor
@athakor athakor commented Nov 14, 2019

Fixes #6361
Updating the JavaDoc only, as @houglum has already addressed this feature in #6183.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 14, 2019
@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 14, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 14, 2019
@athakor athakor changed the title Storage : Updating docstring only of withHostName Storage : Updating docstring of withHostName Nov 14, 2019
@athakor athakor merged commit f5879cd into googleapis:master Nov 14, 2019
@athakor athakor deleted the cloud-storage-6361 branch November 14, 2019 22:46
This was referenced Dec 4, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 Awaiting requested review from chingor13

@JesseLovelace JesseLovelace Awaiting requested review from JesseLovelace

2 more reviewers

@frankyn frankyn frankyn approved these changes

@houglum houglum houglum approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

withHostName method in google-cloud-storage requires URI scheme

5 participants

@athakor @frankyn @houglum @googlebot @yoshi-kokoro
0