8000 Spanner: Remove dependency on GCS by olavloite · Pull Request #6762 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Spanner: Remove dependency on GCS #6762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
olavloite merged 2 commits into from
Nov 14, 2019
Merged

Spanner: Remove dependency on GCS #6762

olavloite merged 2 commits into from
Nov 14, 2019

Conversation

@olavloite
Copy link
@olavloite olavloite commented Nov 13, 2019

Remove the dependency on Google Cloud Storage and throw a descriptive exception for users who are currently using this feature.

Fixes #6708.

@olavloite
remove gcs dependency
7c34187 
Remove the dependency on Google Cloud Storage and throw a descriptive
exception for users who are currently using this feature. Fixes googleapis#6708.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 13, 2019
@olavloite olavloite changed the title remove gcs dependency Spanner: Remove dependency on GCS Nov 13, 2019
@codecov
Copy link
codecov bot commented Nov 13, 2019 •
edited
Loading

Codecov Report

Merging #6762 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6762      +/-   ##
============================================
- Coverage     46.37%   46.37%   -0.01%     
+ Complexity    28024    28022       -2     
============================================
  Files          2614     2614              
  Lines        288317   288303      -14     
  Branches      33810    33810              
============================================
- Hits         133715   133699      -16     
- Misses       144336   144338       +2     
  Partials      10266    10266
Impacted Files Coverage Δ Complexity Δ
.../google/cloud/spanner/jdbc/CredentialsService.java 90.47% <100%> (-0.64%) 8 <0> (-3)
...c/main/java/com/google/cloud/bigquery/Routine.java 79.24% <0%> (-3.11%) 11% <0%> (ø)
...in/java/com/google/cloud/bigquery/RoutineInfo.java 67.47% <0%> (+0.52%) 21% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2d63be...71fb2b0. Read the comment docs.

@olavloite olavloite requested a review from skuruppu November 13, 2019 15:13
@olavloite olavloite merged commit e3074e6 into googleapis:master Nov 14, 2019
@olavloite olavloite deleted the spanner-jdbc-remove-gcs branch November 14, 2019 17:06
This was referenced Dec 4, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@elharo elharo elharo left review comments

@skuruppu skuruppu

skuruppu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Spanner: remove Cloud Storage depedency

4 participants

@olavloite @skuruppu @elharo @googlebot
0