Fix projectName parsing in GapicSpannerRpc #6746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at contain special charecters Like projects within an organizations.
skuruppu
suggested changes
Nov 12, 2019
There was a problem hiding this comment.
If you can also fix the code format issue, that'd be great.
...ents/google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpc.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #6746 +/- ##
============================================
- Coverage 46.37% 46.37% -0.01%
- Complexity 28024 28028 +4
============================================
Files 2614 2615 +1
Lines 288317 288309 -8
Branches 33810 33809 -1
============================================
- Hits 133715 133710 -5
+ Misses 144336 144334 -2
+ Partials 10266 10265 -1
Continue to review full report at Codecov.
|
skuruppu
approved these changes
Nov 14, 2019
...ents/google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpc.java
Outdated
Show resolved
Hide resolved
…ogle/cloud/spanner/spi/v1/GapicSpannerRpc.java Co-Authored-By: skuruppu <skuruppu@google.com>
This was referenced Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To accept project names that contain special characters.
Like projects within an organization.