8000 Bigquerystorage: fix missing dependency. by pmakani · Pull Request #6736 · googleapis/google-cloud-java · GitHub
[go: up one dir, main page]
Skip to content

Bigquerystorage: fix missing dependency. #6736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 2 commits into from
Nov 25, 2019
Merged

Bigquerystorage: fix missing dependency. #6736

chingor13 merged 2 commits into from
Nov 25, 2019

Conversation

@pmakani
Copy link
@pmakani pmakani commented Nov 12, 2019

Fixes #6710

@pmakani pmakani requested review from chingor13 and elharo November 12, 2019 13:06
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 12, 2019
@codecov
Copy link
codecov bot commented Nov 12, 2019 •
edited
Loading

Codecov Report

Merging #6736 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6736      +/-   ##
============================================
+ Coverage     46.37%   46.37%   +<.01%     
+ Complexity    28040    28025      -15     
============================================
  Files          2614     2614              
  Lines        288317   288317              
  Branches      33805    33810       +5     
============================================
+ Hits         133711   133717       +6     
+ Misses       144339   144335       -4     
+ Partials      10267    10265       -2
Impacted Files Coverage Δ Complexity Δ
.../com/google/cloud/pubsub/v1/MessageDispatcher.java 85.12% <0%> (+0.51%) 23% <0%> (ø) ⬇️
...oogle/cloud/spanner/jdbc/SingleUseTransaction.java 87% <0%> (+1%) 37% <0%> (+1%) ⬆️
.../cloud/datastore/testing/LocalDatastoreHelper.java 85.07% <0%> (+4.47%) 17% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b47858f...4a1ef41. Read the comment docs.

elharo
elharo suggested changes Nov 12, 2019
View reviewed changes
google-cloud-bom/pom.xml Outdated
<dependency>
<groupId>com.google.cloud</groupId>
<< 8000 span class="pl-ent">artifactId>google-cloud-bigquerystorage</artifactId>
<version>0.118.1-beta-SNAPSHOT</version><!-- {x-version-update:google-cloud-bigquerystorage:current} -->
Copy link
Contributor
@elharo elharo Nov 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be a snapshot version and maybe not 0.118.1

Copy link
Author
@pmakani pmakani Nov 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 13, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 13, 2019
@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 13, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 13, 2019
@pmakani
Copy link
Author
pmakani commented Nov 13, 2019

@davidrabinowitz PTAL

@pmakani pmakani requested a review from elharo November 13, 2019 11:32
@davidrabinowitz
Copy link
davidrabinowitz commented Nov 13, 2019

Great, thanks!

@pmakani
Copy link
Author
pmakani commented Nov 15, 2019

@elharo PTAL.

@chingor13 chingor13 merged commit 3f1bf3b into googleapis:master Nov 25, 2019
@pmakani pmakani deleted the api-bigquery-6710 branch November 26, 2019 04:37
This was referenced Dec 4, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 approved these changes

+1 more reviewer

@elharo elharo elharo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

com.google.cloud:google-cloud-bigquerystorage is missing from the MOB

7 participants

@pmakani @davidrabinowitz @chingor13 @elharo @googlebot @yoshi-kokoro @athakor
0